Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

[MTB] implement benchmark lifecycle #792

Closed
4 tasks
phoenixking25 opened this issue Jun 6, 2020 · 1 comment
Closed
4 tasks

[MTB] implement benchmark lifecycle #792

phoenixking25 opened this issue Jun 6, 2020 · 1 comment

Comments

@phoenixking25
Copy link
Contributor

Task to run preliminary tests/checks before running benchmarks.

  • Check the given namespace is valid or not.
  • Check the given user/SA is valid or not.
  • Check if there is KubeConfig at $HOME/.kube/config (alternative take kubeconfig from ENV.
  • Check the given user has RBAC privileges to create pods/services/deployments.
@JimBugwadia
Copy link
Contributor

@phoenixking25 - please rename to "implement benchmark lifecycle" or close and open a separate issue. As discussed we can add a common validate function (may be different per level) and then for each benchmark define the lifecycle phases:

  • validate or Pre-Run: if this returns an error the test is marked as "error" instead of "fail".
  • Run: if this returns an error the test is marked as "fail", otherwise "pass".

Not sure if we need a post-run. Thoughts?

@phoenixking25 phoenixking25 changed the title [MTB] Preliminary tests before benchmarks. [MTB] implement benchmark lifecycle Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants