Switched to k8s 1.18.0 as attempt to fix issue #25

[petermicuch]

This is my very first attempt to work with GO at all, so it definitely needs someone more experienced to check. I only installed GO today to fix this.

As right now I have no k8s cluster running version 1.20 I can only test it tomorrow. My main goal was to update dependencies and interfaces so that this runs against k8s 1.18. With that the problem described in issue #25 shall not be present. Actually already version 1.16 should do according to this post.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @petermicuch!

It looks like this is your first PR to kubernetes-sigs/nfs-subdir-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-subdir-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[petermicuch]

I just tested this now and it works. Volume gets created, after PVC deletion volume is removed and respective folder is marked as archived. I have to check with my company if it is fine to sign CLA.

[petermicuch]

I have to do small internal training in my company to be able to sign CLA, so it will take a week or so before I can sign it (I hope not more). If anyone is willing to create another PR bringing in changes or even to bump directly to k8s 1.20.0 I am fine with that. I took versions of client-go as I have seen them in go.mod originally.

[rkevin-arch]

Thank you so much for the PR! It fixed our cluster for now. For anyone still using the (unfortunately deprecated but no replacement available) stable/nfs-client-provisioner helm chart, you can add the following to the helm values:

image:
  repository: rkevin/nfs-subdir-external-provisioner
  tag: fix-k8s-1.20

This image is directly built on this PR. This is a temporary fix until this PR is merged upstream.

[petermicuch]

Almost there with CLA signing. My company representative will sign corporation CLA hopefully today.

[petermicuch]

CLA signed. Please check.

[petermicuch]

@kmova can this one be approved before #29 or will this come after? And do you know if @ashishranjan738 is around for reviews or could you help review this one?

[kmova]

This looks good to me @petermicuch .. I am waiting on @jackielii to confirm if the incorporated changes are good.

Yes, I will hold off on #29 till this is merged. And I also need to work on a few updates to the Dockerfile in that PR.

[kmova]

/lgtm

[petermicuch]

@jackielii , @kmova is this now good to go? I have seen #29 was already merged to master.

[jsafrane]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, petermicuch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fabriciomrtnz]

Thank you so much for the PR! It fixed our cluster for now. For anyone still using the (unfortunately deprecated but no replacement available) stable/nfs-client-provisioner helm chart, you can add the following to the helm values:

image:
  repository: rkevin/nfs-subdir-external-provisioner
  tag: fix-k8s-1.20

This image is directly built on this PR. This is a temporary fix until this PR is merged upstream.

I do not use helm.

What does this translate to in the deployment-arm.yaml definition?

[rkevin-arch]

What does this translate to in the deployment-arm.yaml definition?

Try changing line 24 from image: quay.io/external_storage/nfs-client-provisioner-arm:latest to image: rkevin/nfs-subdir-external-provisioner:fix-k8s-1.20-arm (or image: rkevin/nfs-subdir-external-provisioner:fix-k8s-1.20 for x86_64). Note that this isn't an official image so you should be switching to an official one when it releases.

[groundhog2k]

I created a fork of this repository and used the patch from @petermicuch to create a multi-arch image of the nfs-subdir-external-provisioner. It works with Kubernetes 1.20.x on ARMv8 and AMD64
Feel free to use it.

(I also copies the deprecated stable helm chart - to have a backup until a new offical chart will be available => https://github.com/groundhog2k/helm-charts/tree/master/charts/nfs-client-provisioner)

[ammmze]

Thank you @groundhog2k! I'm just getting my feet wet with kubernetes (just testing via helmfile and k3d ATM) to transition my home server from a docker-compose setup. And I appreciate the multi-arch image as well as I'm thinking I may pick up some raspberry pi's to start distributing my stuff across multiple hosts as well as keeping my AMD machine for GPU workloads.

[colfe34]

Guys thank you so much for this workaround, worked instantly.

[rkevin-arch]

I believe there is an official nfs-subdir-external-provisioner helm chart / image now, so you probably shouldn't be using the workarounds here. Better to switch to an official image.