Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.13] Bump kubernetes to v1.28.1 #1318

Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Aug 29, 2023

This PR cherry-picks multiple commits from the master branch. In addition to bumping kubernetes to v1.28.1 the PR also updates tests accordingly, to make them runnable and pass.

The PR is to fix the topology-updater crashes reported in #1314

Also sync (update) other dependencies with what kubernetes v1.28 has.

(cherry picked from commit 5d5f133)
(cherry picked from commit 4d9259d)
Update mocked implementation of
k8s.io/kubelet/pkg/apis/podresources/v1.PodResourcesListerClient. The
mocked implementation is moved to a separate "mocks" subpackage as it's
for an external interface.

This patch also adds code for auto-generation for the mocked interface.

(cherry picked from commit e2d5ba1)
Eliminate all context.TODO() from the e2e tests and use ginkgo context
instead. This ensures that calls involving context are properly
cancelled and return fast in case the tests get aborted.

(cherry picked from commit ad8bd05)
Add context to functions that now require it. Also, replace the
deprecated wait.Poll* calls with wait.PollUntilContextTimeout.

(cherry picked from commit 87371e2)
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 29, 2023
@marquiz
Copy link
Contributor Author

marquiz commented Aug 29, 2023

/assign @PiotrProkop

@marquiz
Copy link
Contributor Author

marquiz commented Aug 29, 2023

/retest

2 similar comments
@marquiz
Copy link
Contributor Author

marquiz commented Aug 29, 2023

/retest

@marquiz
Copy link
Contributor Author

marquiz commented Aug 29, 2023

/retest

@marquiz
Copy link
Contributor Author

marquiz commented Aug 29, 2023

Let's try with more resources in the prow job...
/retest

@marquiz marquiz force-pushed the devel/release-0.13-k8s-1.28 branch from d0ea679 to 713fa91 Compare August 29, 2023 20:21
@ArangoGutierrez
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7e485e7deb1eb36c5bc15146651e86b9900bbfd0

@k8s-ci-robot k8s-ci-robot merged commit 9be9259 into kubernetes-sigs:release-0.13 Aug 30, 2023
5 of 6 checks passed
@marquiz marquiz deleted the devel/release-0.13-k8s-1.28 branch August 30, 2023 16:49
@marquiz marquiz mentioned this pull request Aug 31, 2023
15 tasks
nrdufour added a commit to nrdufour/home-ops that referenced this pull request Sep 1, 2023
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [node-feature-discovery](https://github.com/kubernetes-sigs/node-feature-discovery) | patch | `0.13.3` -> `0.13.4` |

---

### Release Notes

<details>
<summary>kubernetes-sigs/node-feature-discovery (node-feature-discovery)</summary>

### [`v0.13.4`](https://github.com/kubernetes-sigs/node-feature-discovery/releases/tag/v0.13.4)

[Compare Source](kubernetes-sigs/node-feature-discovery@v0.13.3...v0.13.4)

#### Changelog

This release contains one bug fix to the nfd-topology-updater and makes it runnable in Kubernetes v1.28, in addition to updating dependencies.

#### List of PRs

-   fix empty hugepages in some numa nodes caused no such file or directory errors ([#&#8203;1298](kubernetes-sigs/node-feature-discovery#1298))
-   Bump kubernetes to v1.28.1 ([#&#8203;1318](kubernetes-sigs/node-feature-discovery#1318))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yMy4yIiwidXBkYXRlZEluVmVyIjoiMzYuMjMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://git.home/nrdufour/home-ops/pulls/69
Co-authored-by: Renovate <renovate@ptinem.io>
Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants