Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/update-gh-pages: fix symlink to stable version #724

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jan 11, 2022

Fix the sorting magic of release directories. Correctly sort according
to the version number.

Fix the sorting magic of release directories. Correctly sort according
to the version number.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 11, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 11, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Jan 11, 2022

/assign @ArangoGutierrez

Copy link
Contributor

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -184,7 +184,7 @@ fi
# Switch to work in the gh-pages worktree
pushd "$build_dir" > /dev/null

_stable=`(ls -d1 v*/ || :) | sort -n | tail -n1`
_stable=`(ls -d1 v*/ || :) | sort -V | tail -n1`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a1afaea into kubernetes-sigs:master Jan 11, 2022
@marquiz marquiz deleted the devel/gh-pages branch January 12, 2022 06:21
@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/cherrypick release-0.10

@k8s-infra-cherrypick-robot

@marquiz: new pull request created: #746

In response to this:

/cherrypick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/cherrypick release-0.9
/cherrypick release-0.8
/cherrypick release-0.7

@k8s-infra-cherrypick-robot

@marquiz: new pull request created: #747

In response to this:

/cherrypick release-0.9
/cherrypick release-0.8
/cherrypick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/cherrypick release-0.8 release-0.7

@k8s-infra-cherrypick-robot

@marquiz: cannot checkout release-0.8 release-0.7: error checking out release-0.8 release-0.7: exit status 1. output: error: pathspec 'release-0.8 release-0.7' did not match any file(s) known to git

In response to this:

/cherrypick release-0.8 release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/cherrypick release-0.8

@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/cherrypick release-0.7

@k8s-infra-cherrypick-robot

@marquiz: new pull request created: #749

In response to this:

/cherrypick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@marquiz: new pull request created: #750

In response to this:

/cherrypick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz marquiz mentioned this pull request Mar 17, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants