-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase timeout in test setups #738
Conversation
This patch increases the timeout when setting up the NFD master to 5 seconds instead of 1 second to allow for running tests in slow environments.
|
Welcome @mnaser! |
Hi @mnaser. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I've signed the CLA. |
OK, looks like there is two CLAs or something? I signed the second one too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mnaser! Hope 5s is enough for everyone 🤞
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz, mnaser The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We need #732: |
@marquiz: Overrode contexts on behalf of marquiz: pull-node-feature-discovery-build-image In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5s are enough in slow environments when building natively, but it is not enough for virtualized builds. I had a 20s timeout and it sometimes failed. Running buildx in a slow environment with 5s can still fail ... |
@zvonkok do you think we should bump it to 20 seconds? It probably doesn't hurt but makes the builds wrk better. Ideally, the whole timeout shouldn't be a thing but eh.. |
This patch increases the timeout when setting up the NFD master
to 5 seconds instead of 1 second to allow for running tests in
slow environments.
Closes: #737