Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: configure docker auth in push-image.sh #739

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jan 21, 2022

Re-introduce docker authentication that was dropped in
bac6908. Should fix issues with
building multi-arch buildx buildx.

Re-introduce docker authentication that was dropped in
bac6908. Should fix issues with
building multi-arch buildx buildx.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/assign @zvonkok

@zvonkok
Copy link
Contributor

zvonkok commented Jan 21, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2022
@zvonkok
Copy link
Contributor

zvonkok commented Jan 21, 2022

/override pull-node-feature-discovery-build-image

@k8s-ci-robot
Copy link
Contributor

@zvonkok: zvonkok unauthorized: /override is restricted to Repo administrators.

In response to this:

/override pull-node-feature-discovery-build-image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zvonkok
Copy link
Contributor

zvonkok commented Jan 21, 2022

/joke

@k8s-ci-robot
Copy link
Contributor

@zvonkok: I had a rough day, and then somebody went and ripped the front and back pages from my dictionary. It just goes from bad to worse.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zvonkok
Copy link
Contributor

zvonkok commented Jan 21, 2022

/meow

@k8s-ci-robot
Copy link
Contributor

@zvonkok: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marquiz
Copy link
Contributor Author

marquiz commented Jan 21, 2022

/override pull-node-feature-discovery-build-image

@k8s-ci-robot
Copy link
Contributor

@marquiz: Overrode contexts on behalf of marquiz: pull-node-feature-discovery-build-image

In response to this:

/override pull-node-feature-discovery-build-image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 60adfe8 into kubernetes-sigs:master Jan 21, 2022
@marquiz marquiz deleted the devel/gcloud-auth branch January 21, 2022 08:21
@marquiz marquiz mentioned this pull request Mar 17, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants