Add ServiceAccount for nfd-worker

[mac-chaffee]

This PR creates a separate ServiceAccount for the nfd-worker like the other components.

Even though the nfd-worker doesn't need any special RBAC permissions, this feature is useful for nvidia/gpu-operator which supports PodSecurityPolicies. But since nfd-worker doesn't have its own ServiceAccount, they've bolted on this feature into their fork, which is giving them issues: NVIDIA/gpu-operator#314 https://gitlab.com/nvidia/kubernetes/gpu-operator/-/merge_requests/414#note_854845708

PodSecurityPolicies are used to grant special permission to nfd-worker to create hostPath volumes.

[k8s-ci-robot]

Welcome @mac-chaffee!

It looks like this is your first PR to kubernetes-sigs/node-feature-discovery 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/node-feature-discovery has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @mac-chaffee. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adrianchiris]

/ok-to-test

[adrianchiris]

@mac-chaffee could you add the information in the PR description to the commit message ? (minus links)

[marquiz]

I think this looks good. Just the helm lint does not pass muster so you need to fix that.

Two questions I was pondering:

1. should we create the SA by default? I think it's probably easier as it is now and shouldn't have any negative effects (except for perhaps the question why is it created if it's not used for anything by the default deployment)
2. Should the kustomize deployment be aligned. Again, I think probably not and it is fine the way it is now

[adrianchiris]

as a note, PodSecurityPolicy is going to be removed at k8s 1.25
see : https://kubernetes.io/docs/concepts/policy/pod-security-policy/

so eventually we will not need this IMO.

my 2 cents for now:

should we create the SA by default? I think it's probably easier as it is now and shouldn't have any negative effects (except for perhaps the question why is it created if it's not used for anything by the default deployment)

i think we can create by default, maybe a comment in helm values to explain why we create this for now ?

Should the kustomize deployment be aligned. Again, I think probably not and it is fine the way it is now

it would be nice if the two ways to deploy NFD are aligned but it can be added in later if needed. (not sure how common deployment via kustomize is apart of dev/ci env. these to my experience usually dont enable PSP)

[adrianchiris]

/lgtm

[marquiz]

Looks good @mac-chaffee 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mac-chaffee, marquiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [marquiz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment