Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option to disable hooks #859

Closed
marquiz opened this issue Aug 16, 2022 · 3 comments · Fixed by #871
Closed

Config option to disable hooks #859

marquiz opened this issue Aug 16, 2022 · 3 comments · Fixed by #871
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@marquiz
Copy link
Contributor

marquiz commented Aug 16, 2022

What would you like to be added:

Add a config file option to disable hooks of the local feature source, e.g.

sources:
  local:
    hooksEnabled: true  # true by default at this point

Also, add a disclaimer in docs and logs that hooks are now deprecated and will be disabled in a future release (and eventually removed alltogether).

Why is this needed:

First step of #856.

@marquiz marquiz added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 16, 2022
@marquiz marquiz added this to the v.0.12.0 milestone Aug 16, 2022
@marquiz
Copy link
Contributor Author

marquiz commented Aug 16, 2022

/cc @zvonkok
ping @mythi

@fmuyassarov
Copy link
Member

I'm interested to work on this issue
/assign

@marquiz
Copy link
Contributor Author

marquiz commented Aug 19, 2022

I'm interested to work on this issue

That would be great! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants