Welcome @prb112!

It looks like this is your first PR to kubernetes-sigs/scheduler-plugins 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/scheduler-plugins has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @prb112. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

✅ Deploy Preview for kubernetes-sigs-scheduler-plugins canceled.

We're going to verify the commands (I meant to put as WIP)

/ok-to-test

I'd be in favor of this support, but we need to check we have available machines in CI

I'd be in favor of this support, but we need to check we have available machines in CI

Thank you @ffromani

/assign

Hey @ffromani and team, @Chandan-Abhyankar and I have completed our testing. I have removed the work in progress label. We look forward to your review and comments and next steps. Thank you, Paul

@prb112 how urgent you'd like to merge this PR? I'm thinking of support distroless image building so that we have a unified image that works for all archs:

• amd64
• arm64
• s390x
• ppc64le

@prb112 how urgent you'd like to merge this PR? I'm thinking of support distroless image building so that we have a unified image that works for all archs:

Hi @Huang-Wei I'd love to get this sooner than later - our testing starts in 1-2 weeks. We have a custom build. As long as the distroless arrives in a month, it would work with our usecase too. Thanks, Paul

As long as the distroless arrives in a month, it would work with our usecase too.

Usually we cut releases every 3~4 months, so it's possible to get the distroless build code in, and cut a 1.29 release in early July. Does that sound feasible?

(BTW: even we proceed with this PR as a temporary solution, we will still have to wait until early July for the new release.)

As long as the distroless arrives in a month, it would work with our usecase too.

Usually we cut releases every 3~4 months, so it's possible to get the distroless build code in, and cut a 1.29 release in early July. Does that sound feasible?

(BTW: even we proceed with this PR as a temporary solution, we will still have to wait until early July for the new release.)

Hey @Huang-Wei that sounds a-OK. Is this something we could help complete? Is there a scope of work / containerfiles that would need to be changed? Many thanks, Paul

Is this something we could help complete?

@prb112 definitely, fell free to self-assign to work on it.

Is there a scope of work / containerfiles that would need to be changed?

Other Kubernetes sub-projects have some existing examples. I usually use cs.k8s.io to search - here one example (keyword: gcr.io/distroless/static:nonroot)

Hi ... apologies, which issue #, and then I'll assign. Thank you, Paul

I created #756 to track the distroless build work.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prb112
Once this PR has been reviewed and has the lgtm label, please ask for approval from ffromani. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

/wip

Hi @Huang-Wei
Hope all is well. The distroless build details are included in this PR.
We've confirmed it builds the correct images.
Please let us know if you have any review/comments.
Thanks
Paul