Add version subcommand and CLI parser #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschagrunert
force-pushed
the
version
branch
4 times, most recently
from
eddf70d
to
cc93be2
Compare
|
@hasheddan @pjbgf please take a look :) |
pjbgf
approved these changes
Jun 28, 2020
| require.NotEmpty(t, sut.String()) | ||
| } | ||
|
|
||
| func TestVersionJSON(t *testing.T) { |
There was a problem hiding this comment.
nit: would be nice to have tests for unknown versions and also when the version is known.
There was a problem hiding this comment.
Hm this is done via the $LDVARS so I'm not sure how exactly test both cases. In any case I added the vars to the test-unit target so we now can check that they're not empty per default.
saschagrunert
force-pushed
the
version
branch
2 times, most recently
from
22e546e
to
d01f54b
Compare
To be able to identify the seccomp operator build appropriately we now provide a `version,v` command. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
jhrozek
pushed a commit
to jhrozek/security-profiles-operator
that referenced
this pull request
Dec 16, 2022
OCPBUGS-3690: profilerecorder: gracefully skip containers that did not record anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
To be able to identify the seccomp operator build appropriately we now
provide a
version,vcommand.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?