Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/istio] istio install failed #2447

Closed
gyliu513 opened this issue Oct 10, 2017 · 16 comments
Closed

[incubator/istio] istio install failed #2447

gyliu513 opened this issue Oct 10, 2017 · 16 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@gyliu513
Copy link
Contributor

Is this a request for help?:


Is this a BUG REPORT or FEATURE REQUEST? (choose one):

Version of Helm and Kubernetes:

Which chart:
istio

What happened:

Lins-MacBook-Pro:Downloads linsun$ helm repo add incubator http://storage.googleapis.com/kubernetes-charts-incubator
"incubator" has been added to your repositories
Lins-MacBook-Pro:Downloads linsun$ helm install --name istio incubator/istio --namespace istio-system
Error: file "incubator/istio" not found

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

@gyliu513
Copy link
Contributor Author

Related with istio/istio.io#531 (comment)

/cc @linsun @lachie83

@rimusz
Copy link
Contributor

rimusz commented Oct 10, 2017

this is the problem https://github.com/kubernetes/charts/blob/master/incubator/istio/Chart.yaml#L6 why istio chart can't be installed from helm repos

@gyliu513
Copy link
Contributor Author

Why version: 0.2.7-chart2 caused the install failed from incubator repo? Can you please elaborate? Any comments for how to make this work? @rimusz

@rimusz
Copy link
Contributor

rimusz commented Oct 10, 2017

helm does not like version: 0.2.7-chart2 it breaks it's semver logic.
as soon you change to version: 0.2.7, istio install from remote helm repo works again

@gyliu513
Copy link
Contributor Author

Thanks @rimusz , this seems to be a limitation of semver https://github.com/Masterminds/semver/blob/master/constraints_test.go#L296 , if use version: 0.2.7, then we will not able to track all of the different versions, what do you think @ldemailly @lachie83

@rimusz
Copy link
Contributor

rimusz commented Oct 10, 2017

@gyliu513 chart version does not have to be the same as app's :)

@lachie83
Copy link
Contributor

The chart version does conform to semver v2 but it falls under pre-release so you have to use the --devel flag upon install. We are working on ways to expose the appVersion as it may be more relevant to some users. See helm/helm#3009 and it's related issue to expose appVersion in search

@linsun
Copy link

linsun commented Oct 10, 2017

Could we change it to version: 2.0.7 so that the istio helm chart can work given istio 0.2.7 is just announced today?

@lachie83
Copy link
Contributor

Would like to get something definitive from @ldemailly given that I've been working with him on this.

helm/helm#3009 (comment)

@lachie83
Copy link
Contributor

Also some additional context that I've been working with the Helm upstream developers on helm/helm#3010 cc @ldemailly

@ldemailly
Copy link
Contributor

apologies for the lag: the search isn't there yet, is it

I assume you are asking if we can decouple the 2 versions, I prefer we keep them in lockstep if possible but if not practical maybe having 0.2.7-pre1 ... until it seems to be "working" enough to promote it to 0.2.7 ?

if we decouple the versions, what would the helm one look like ? (1.0.x ?)

@linsun
Copy link

linsun commented Oct 12, 2017

I'd prefer to keep the istio helm chart version and istio version in sync as that reduces a lot of confusion.

Since Istio 0.2.8 is coming out this week and contains critical fixes, is it possible to allow users to always install the latest Istio in 0.2.x and optionally user can specify a particular version of 0.2, like 0.2.7 or 0.2.8 or 0.2.9 to install?

@lachie83
Copy link
Contributor

I don't think keeping the versions in sync is the right approach. The chart version indicates a set of values and templated Kubernetes resource definitions which is not actually intrinsically linked to the application version. I don't want to lock a released chart in so that it cannot be modified within the same semver release as things change all the time and functionality may be added or removed at any point.

I do however think that we could do a better job bubbling up the application version as a searchable and installable install time flag. Out of the 80+ upstream charts no one has flagged this a serious issue for users. Services like monocular expose the appVersion in a nicer way - https://kubeapps.com/charts?q=istio

I think given the current ask it's best simply make the chart versions so different that they cannot possibly be confused. Possibly 10.0.0 to start. Hopefully by that time we have a reasonable approach to the exposing the app version.

@lachie83
Copy link
Contributor

The next release of helm will allow you to search via app version. Does this help?
helm/helm#3059

@stealthybox
Copy link
Collaborator

Current workaround:

helm install --name istio incubator/istio --namespace istio-system --devel --version 0.2.7-chart2
helm upgrade istio incubator/istio --reuse-values --set istio.install=true --devel --version 0.2.7-chart2

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

8 participants