Add rocket.chat #752

Merged
merged 10 commits into from Jul 5, 2017

Conversation

Projects
None yet
9 participants
@pierreozoux
Contributor

pierreozoux commented Mar 3, 2017

No description provided.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Mar 3, 2017

Contributor

Hi @pierreozoux. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Mar 3, 2017

Hi @pierreozoux. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Mar 3, 2017

Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Mar 3, 2017

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierreozoux pierreozoux referenced this pull request in RocketChat/Rocket.Chat Mar 13, 2017

Merged

Add helm chart kubernetes deployment #6340

2 of 3 tasks complete
+ name: {{ template "fullname" . }}
+ key: mongo-uri
+ {{ else }}
+ value: mongodb://{{ template "mongodb.fullname" . }}:27017/meteor

This comment has been minimized.

@geekgonecrazy

geekgonecrazy Mar 13, 2017

To increase consistency with other Rocket.Chat documentation maybe use rocketchat as the db name here?

@geekgonecrazy

geekgonecrazy Mar 13, 2017

To increase consistency with other Rocket.Chat documentation maybe use rocketchat as the db name here?

stable/rocketchat/templates/ingress.yaml
+ name: {{ template "fullname" . }}
+ annotations:
+ kubernetes.io/tls-acme: "true"
+ kubernetes.io/ingress.class: nginx

This comment has been minimized.

@geekgonecrazy

geekgonecrazy Mar 13, 2017

This automatically assumes they have an nginx ingress running. Is this safe?

@geekgonecrazy

geekgonecrazy Mar 13, 2017

This automatically assumes they have an nginx ingress running. Is this safe?

This comment has been minimized.

@linki

linki Mar 16, 2017

Member

It should be commented out by default. Similar to

# kubernetes.io/ingress.class: nginx

This will allow the Chart to work by default. People that use the nginx-based ingress controller can either opt-in by setting this to "nginx" or they configure their cluster/ingress-controller to pick up Ingresses without annotations, too (like GKE does).

@linki

linki Mar 16, 2017

Member

It should be commented out by default. Similar to

# kubernetes.io/ingress.class: nginx

This will allow the Chart to work by default. People that use the nginx-based ingress controller can either opt-in by setting this to "nginx" or they configure their cluster/ingress-controller to pick up Ingresses without annotations, too (like GKE does).

@linki

This comment has been minimized.

Show comment
Hide comment
@linki

linki Mar 16, 2017

Member

@pierreozoux can you have another look at this?

@geekgonecrazy Thanks for your thoughts.

Member

linki commented Mar 16, 2017

@pierreozoux can you have another look at this?

@geekgonecrazy Thanks for your thoughts.

@pierreozoux

This comment has been minimized.

Show comment
Hide comment
@pierreozoux

pierreozoux Mar 20, 2017

Contributor

@linki I addressed all the comments already (I didn't comment, I just fixed it to avoid noise).

But yeah, thanks @geekgonecrazy for your comments, I fixed them all :)

Let me know if there is anything more needed?

Contributor

pierreozoux commented Mar 20, 2017

@linki I addressed all the comments already (I didn't comment, I just fixed it to avoid noise).

But yeah, thanks @geekgonecrazy for your comments, I fixed them all :)

Let me know if there is anything more needed?

@@ -0,0 +1 @@
+.git

This comment has been minimized.

@linki

linki Mar 22, 2017

Member

This is not the standard .gitignore. Let's wait on the outcome of https://github.com/kubernetes/charts/pull/485/files#r106305261

Looks like we prefer the "canonical" helmignore from now on but many charts still have just this. It probably makes more sense to sync them up in a separate PR across all charts.

@linki

linki Mar 22, 2017

Member

This is not the standard .gitignore. Let's wait on the outcome of https://github.com/kubernetes/charts/pull/485/files#r106305261

Looks like we prefer the "canonical" helmignore from now on but many charts still have just this. It probably makes more sense to sync them up in a separate PR across all charts.

@pierreozoux

This comment has been minimized.

Show comment
Hide comment
@pierreozoux

pierreozoux Apr 19, 2017

Contributor

Is there anything I can do to get this merged?

Contributor

pierreozoux commented Apr 19, 2017

Is there anything I can do to get this merged?

@engelgabriel

This comment has been minimized.

Show comment
Hide comment
@engelgabriel

engelgabriel Apr 19, 2017

The Rocket.Chat team is looking forward for this!

The Rocket.Chat team is looking forward for this!

@geekgonecrazy

This comment has been minimized.

Show comment
Hide comment
@geekgonecrazy

geekgonecrazy Apr 19, 2017

@pierreozoux one thing to maybe add here is the environment variables to populate the INSTANCE_IP variable with the pod ip.

Here is a snippet I have for adding this to the schema:

name: INSTANCE_IP
valueFrom:
  fieldRef:
    fieldPath: status.podIP

This way if scaled the instances can know how to talk to each other over the overlay network

geekgonecrazy commented Apr 19, 2017

@pierreozoux one thing to maybe add here is the environment variables to populate the INSTANCE_IP variable with the pod ip.

Here is a snippet I have for adding this to the schema:

name: INSTANCE_IP
valueFrom:
  fieldRef:
    fieldPath: status.podIP

This way if scaled the instances can know how to talk to each other over the overlay network

@pierreozoux

This comment has been minimized.

Show comment
Hide comment
@pierreozoux

pierreozoux Apr 20, 2017

Contributor

@geekgonecrazy hum, do you have the link to the documentation?

If the person uses S3, it would scale automatically out of the box.
Let's think about this INSTANCE_IP (which is a better way I guess) for another PR, once this got merged?

Contributor

pierreozoux commented Apr 20, 2017

@geekgonecrazy hum, do you have the link to the documentation?

If the person uses S3, it would scale automatically out of the box.
Let's think about this INSTANCE_IP (which is a better way I guess) for another PR, once this got merged?

@geekgonecrazy

This comment has been minimized.

Show comment
Hide comment
@geekgonecrazy

geekgonecrazy Apr 26, 2017

@pierreozoux
Here's a snippet directly out of one of our deployments:
testdeploy.yaml

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  labels:
    DeploymentDomain: testdeploy.rocket.chat
    DeploymentName: testdeploy
  name: testdeploy
  namespace: <namespace here>
spec:
  replicas: 2
  revisionHistoryLimit: 1
  selector:
    matchLabels:
      DeploymentDomain: testdeploy.rocket.chat
      DeploymentName: testdeploy
  strategy:
    rollingUpdate:
      maxSurge: 1
      maxUnavailable: 1
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        DeploymentDomain: testdeploy.rocket.chat
        DeploymentName: testdeploy
    spec:
      containers:
      - env:
        - name: INSTANCE_IP
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: status.podIP
        - <another 10-20 ommited for briefness>
        image: rocketchat/rocket.chat:0.55.1
        imagePullPolicy: IfNotPresent
        name: testdeploy
        ports:
        - containerPort: 3000
          protocol: TCP
Its for sure something that could be added in later.

geekgonecrazy commented Apr 26, 2017

@pierreozoux
Here's a snippet directly out of one of our deployments:
testdeploy.yaml

apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  labels:
    DeploymentDomain: testdeploy.rocket.chat
    DeploymentName: testdeploy
  name: testdeploy
  namespace: <namespace here>
spec:
  replicas: 2
  revisionHistoryLimit: 1
  selector:
    matchLabels:
      DeploymentDomain: testdeploy.rocket.chat
      DeploymentName: testdeploy
  strategy:
    rollingUpdate:
      maxSurge: 1
      maxUnavailable: 1
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        DeploymentDomain: testdeploy.rocket.chat
        DeploymentName: testdeploy
    spec:
      containers:
      - env:
        - name: INSTANCE_IP
          valueFrom:
            fieldRef:
              apiVersion: v1
              fieldPath: status.podIP
        - <another 10-20 ommited for briefness>
        image: rocketchat/rocket.chat:0.55.1
        imagePullPolicy: IfNotPresent
        name: testdeploy
        ports:
        - containerPort: 3000
          protocol: TCP
Its for sure something that could be added in later.
@viglesiasce

This comment has been minimized.

Show comment
Hide comment
@viglesiasce

viglesiasce May 5, 2017

Member

@k8s-bot ok to test

Member

viglesiasce commented May 5, 2017

@k8s-bot ok to test

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot May 5, 2017

Contributor

@pierreozoux: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
Jenkins Charts e2e c11f527 link @k8s-bot e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented May 5, 2017

@pierreozoux: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
Jenkins Charts e2e c11f527 link @k8s-bot e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -0,0 +1,65 @@
+{{- if include "host" . -}}

This comment has been minimized.

@viglesiasce

viglesiasce May 5, 2017

Member

What is this line trying to do? Shouldnt it be:

{{- if .Values.host -}}

@viglesiasce

viglesiasce May 5, 2017

Member

What is this line trying to do? Shouldnt it be:

{{- if .Values.host -}}

This comment has been minimized.

@viglesiasce

viglesiasce May 5, 2017

Member

The linter is also complaining about it and I the pod is crashing with the following when it is not set:

/app/bundle/programs/server/boot.js:356
}).run();
   ^

Error: $ROOT_URL, if specified, must be an URL
    at Error (native)
    at packages/meteor.js:1218:13
    at packages/meteor.js:1233:4
    at packages/meteor.js:1380:3
    at /app/bundle/programs/server/boot.js:303:34
    at Array.forEach (native)
    at Function._.each._.forEach (/app/bundle/programs/server/node_modules/underscore/underscore.js:79:11)
    at /app/bundle/programs/server/boot.js:128:5
    at /app/bundle/programs/server/boot.js:352:5
    at Function.run (/app/bundle/programs/server/profile.js:510:12)

If this is a required field look at what ghost and gitlab-ce have done for this use case.

@viglesiasce

viglesiasce May 5, 2017

Member

The linter is also complaining about it and I the pod is crashing with the following when it is not set:

/app/bundle/programs/server/boot.js:356
}).run();
   ^

Error: $ROOT_URL, if specified, must be an URL
    at Error (native)
    at packages/meteor.js:1218:13
    at packages/meteor.js:1233:4
    at packages/meteor.js:1380:3
    at /app/bundle/programs/server/boot.js:303:34
    at Array.forEach (native)
    at Function._.each._.forEach (/app/bundle/programs/server/node_modules/underscore/underscore.js:79:11)
    at /app/bundle/programs/server/boot.js:128:5
    at /app/bundle/programs/server/boot.js:352:5
    at Function.run (/app/bundle/programs/server/profile.js:510:12)

If this is a required field look at what ghost and gitlab-ce have done for this use case.

@geekgonecrazy

This comment has been minimized.

Show comment
Hide comment
@geekgonecrazy

geekgonecrazy May 10, 2017

@pierreozoux do you need any help getting these changes made? Would be glad to help out

geekgonecrazy commented May 10, 2017

@pierreozoux do you need any help getting these changes made? Would be glad to help out

@pierreozoux

This comment has been minimized.

Show comment
Hide comment
@pierreozoux

pierreozoux May 23, 2017

Contributor

@viglesiasce thanks I addressed your comment.

Contributor

pierreozoux commented May 23, 2017

@viglesiasce thanks I addressed your comment.

@pierreozoux

This comment has been minimized.

Show comment
Hide comment
@pierreozoux

pierreozoux May 31, 2017

Contributor

Is there anything else I can do to help?

Contributor

pierreozoux commented May 31, 2017

Is there anything else I can do to help?

@geekgonecrazy

This comment has been minimized.

Show comment
Hide comment
@geekgonecrazy

geekgonecrazy Jun 8, 2017

@viglesiasce / @linki we would love to see this progress forward. Is there anything you guys need on this to get it merged?

@viglesiasce / @linki we would love to see this progress forward. Is there anything you guys need on this to get it merged?

stable/rocketchat/Chart.yaml
+sources:
+- https://github.com/RocketChat/Docker.Official.Image/
+maintainers:
+- name: Rocket.Chat

This comment has been minimized.

@unguiculus

unguiculus Jun 14, 2017

Member

Use Github username.

@unguiculus

unguiculus Jun 14, 2017

Member

Use Github username.

+metadata:
+ name: {{ template "fullname" . }}
+ labels:
+ app: {{ template "fullname" . }}

This comment has been minimized.

@unguiculus

unguiculus Jun 14, 2017

Member

app label should be {{ template "name" . }}. Apply everywhere.

@unguiculus

unguiculus Jun 14, 2017

Member

app label should be {{ template "name" . }}. Apply everywhere.

stable/rocketchat/templates/svc.yaml
+ port: 3000
+ targetPort: http
+ selector:
+ app: {{ template "fullname" . }}

This comment has been minimized.

@unguiculus

unguiculus Jun 14, 2017

Member

After changing the app label as mentioned above, the selector should be as follows:

app: {{ template "name" . }}
release: "{{ .Release.Name }}"
@unguiculus

unguiculus Jun 14, 2017

Member

After changing the app label as mentioned above, the selector should be as follows:

app: {{ template "name" . }}
release: "{{ .Release.Name }}"
stable/rocketchat/values.yaml
+## Configure resource requests and limits
+## ref: http://kubernetes.io/docs/user-guide/compute-resources/
+##
+resources:

This comment has been minimized.

@unguiculus

unguiculus Jun 14, 2017

Member

We've started recommending not to specify default resources.

@unguiculus

unguiculus Jun 14, 2017

Member

We've started recommending not to specify default resources.

@pierreozoux

This comment has been minimized.

Show comment
Hide comment
@pierreozoux

pierreozoux Jun 20, 2017

Contributor

@unguiculus Thanks for your comment, I addressed them.

Contributor

pierreozoux commented Jun 20, 2017

@unguiculus Thanks for your comment, I addressed them.

+sources:
+- https://github.com/RocketChat/Docker.Official.Image/
+maintainers:
+- name: RocketChat

This comment has been minimized.

@unguiculus

unguiculus Jun 20, 2017

Member

Name should be a Github user.

@unguiculus

unguiculus Jun 20, 2017

Member

Name should be a Github user.

This comment has been minimized.

@geekgonecrazy

geekgonecrazy Jun 20, 2017

@unguiculus this is the org name. Do we need to add individual maintainers listed here?

@geekgonecrazy

geekgonecrazy Jun 20, 2017

@unguiculus this is the org name. Do we need to add individual maintainers listed here?

This comment has been minimized.

@geekgonecrazy

geekgonecrazy Jun 26, 2017

@pierreozoux I can provide a list from Rocket.Chat that would handle any issues that would arise as well as of course your self.

@geekgonecrazy

geekgonecrazy Jun 26, 2017

@pierreozoux I can provide a list from Rocket.Chat that would handle any issues that would arise as well as of course your self.

This comment has been minimized.

@geekgonecrazy

geekgonecrazy Jun 29, 2017

@unguiculus I notice many of the bitnami created ones refer to their org name on github and add an email address. But i've gone ahead and added two additional maintainers by github username.

@geekgonecrazy

geekgonecrazy Jun 29, 2017

@unguiculus I notice many of the bitnami created ones refer to their org name on github and add an email address. But i've gone ahead and added two additional maintainers by github username.

stable/rocketchat/templates/NOTES.txt
+
+You can easily connect to the remote instance from your browser. Forward the webserver port to localhost:8888
+
+- kubectl port-forward --namespace {{ .Release.Namespace }} $(kubectl get pods --namespace {{ .Release.Namespace }} -l app={{ template "fullname" . }} -o jsonpath='{ .items[0].metadata.name }') 8888

This comment has been minimized.

@unguiculus

unguiculus Jun 20, 2017

Member

Fix label selectors:
-l app="{{ template "fullname" . }},release={{ .Release.Name }}"

@unguiculus

unguiculus Jun 20, 2017

Member

Fix label selectors:
-l app="{{ template "fullname" . }},release={{ .Release.Name }}"

This comment has been minimized.

@geekgonecrazy

geekgonecrazy Jun 29, 2017

Fixed, also added these labels to the actual pod level so the command would work in the first place :)

@geekgonecrazy

geekgonecrazy Jun 29, 2017

Fixed, also added these labels to the actual pod level so the command would work in the first place :)

@@ -0,0 +1,65 @@
+{{- if default "" .Values.host }}

This comment has been minimized.

@unguiculus

unguiculus Jun 20, 2017

Member

This is empty by default. When I install the chart with defaults only MongoDB comes up. It should be possible to install a chart with default values.

@unguiculus

unguiculus Jun 20, 2017

Member

This is empty by default. When I install the chart with defaults only MongoDB comes up. It should be possible to install a chart with default values.

This comment has been minimized.

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Jun 29, 2017

Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Jun 29, 2017

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

geekgonecrazy added some commits Jun 29, 2017

Improved Labels, Chart Defaults, Notes
* Add labels to pod for proper kubectl selection
* Allow chart to be installed with no values set
* Improved output notes
@geekgonecrazy

This comment has been minimized.

Show comment
Hide comment
@geekgonecrazy

geekgonecrazy Jun 29, 2017

Bump to verify CLA

Bump to verify CLA

geekgonecrazy added some commits Jun 29, 2017

@geekgonecrazy

This comment has been minimized.

Show comment
Hide comment
@geekgonecrazy

geekgonecrazy Jun 30, 2017

Helping @pierreozoux get things finished here.

@unguiculus @viglesiasce I think i've now addressed all feedback.

  • Added maintainers. I went ahead and left our org and email for contact, and added two maintainers to the list.
  • Fixed Notes so the output will suggest how to get site going at http://chat.yourdomain.com. Fixed a few selectors in the queries it says to run as well as the port forward port
  • Now can be installed with as little as: helm install stable/rocketchat brings up mongodb and rocket.chat

I've also signed the CLA

Helping @pierreozoux get things finished here.

@unguiculus @viglesiasce I think i've now addressed all feedback.

  • Added maintainers. I went ahead and left our org and email for contact, and added two maintainers to the list.
  • Fixed Notes so the output will suggest how to get site going at http://chat.yourdomain.com. Fixed a few selectors in the queries it says to run as well as the port forward port
  • Now can be installed with as little as: helm install stable/rocketchat brings up mongodb and rocket.chat

I've also signed the CLA

@geekgonecrazy

This comment has been minimized.

Show comment
Hide comment
@geekgonecrazy

geekgonecrazy Jul 5, 2017

@viglesiasce @unguiculus @linki would any of you guys be able to take a look at this?

@viglesiasce @unguiculus @linki would any of you guys be able to take a look at this?

@viglesiasce

This comment has been minimized.

Show comment
Hide comment
@viglesiasce

viglesiasce Jul 5, 2017

Member

@geekgonecrazy I'll take a look today.

Member

viglesiasce commented Jul 5, 2017

@geekgonecrazy I'll take a look today.

@geekgonecrazy

This comment has been minimized.

Show comment
Hide comment
@geekgonecrazy

geekgonecrazy Jul 5, 2017

@viglesiasce thank you! I've also joined in the slack #helm-users channel and glad to chat and address what ever concerns if any still remain.

@viglesiasce thank you! I've also joined in the slack #helm-users channel and glad to chat and address what ever concerns if any still remain.

@viglesiasce

This comment has been minimized.

Show comment
Hide comment
@viglesiasce

viglesiasce Jul 5, 2017

Member

Worked a treat! Thanks!

Member

viglesiasce commented Jul 5, 2017

Worked a treat! Thanks!

@viglesiasce viglesiasce merged commit 496c968 into kubernetes:master Jul 5, 2017

2 checks passed

cla/linuxfoundation geekgonecrazy authorized
Details
pull-charts-e2e Jenkins job succeeded.
Details
@geekgonecrazy

This comment has been minimized.

Show comment
Hide comment

Perfect! Thanks @viglesiasce !

@pierreozoux pierreozoux deleted the pierreozoux:rocket.chat branch Jul 6, 2017

@pierreozoux

This comment has been minimized.

Show comment
Hide comment
@pierreozoux

pierreozoux Jul 6, 2017

Contributor

\o/ Thanks!

Contributor

pierreozoux commented Jul 6, 2017

\o/ Thanks!

lachie83 added a commit to lachie83/charts that referenced this pull request Jul 10, 2017

Merge remote-tracking branch 'upstream/master'
* upstream/master: (67 commits)
  Fix json whitespace (#1458)
  Use consistent whitespace in template placeholders (#1437)
  [stable/selenium] Make hub readiness probe timeout configurable (#1391)
  [stable/kube2iam]: add rbac support (#1286)
  [stable/traefik] Allow enabling traefik access logs (#1302)
  Add Stash chart (#1420)
  Add Gearman G2 chart (#1421)
  add option to include tolerations to daemonset (#1364)
  Moved Artifactory to stable and updated version to 5.3.2 (#1314)
  Concourse postgres conditional dependency (#1390)
  Typo in helm install command for dask-distributed (#1413)
  [stable/fluent-bit] Fluent Bit v0.11.12 (#1417)
  fixed cassandra chart's persistence bug (#1245)
  Prometheus: modify config to support k8s 1.6 by default (#1080)
  Add rocket.chat (#752)
  Fix influxdb deployment (#1424)
  feat(stable/etcd-operator): add support for supplying additional command args (#1418)
  add configurable service annotations #1234 (#1244)
  [stable/prometheus] extra environment variable for alert manager (#1237)
  [stable/heapster] Default service name to Heapster (#1266)
  ...

yanns pushed a commit to yanns/charts that referenced this pull request Jul 28, 2017

Add rocket.chat (#752)
* Add rocket.chat

* Add additional maintainers beyond the github org

* Fix mongo dependency

* Improved Labels, Chart Defaults, Notes
* Add labels to pod for proper kubectl selection
* Allow chart to be installed with no values set
* Improved output notes

* add helm chart to suggested install command

* Add deploy platform environment variable

* Add Instance IP to pod env variable to make scaling easier

* Switch app name to use app's name

* Update to latest Rocket.Chat version

* Remove else from ROOT_URL, its not needed
@sathieu

This comment has been minimized.

Show comment
Hide comment
@sathieu

sathieu Nov 29, 2017

Contributor

Hello,

It is not on https://kubeapps.com/. Can someone push it?

Contributor

sathieu commented Nov 29, 2017

Hello,

It is not on https://kubeapps.com/. Can someone push it?

@sathieu

This comment has been minimized.

Show comment
Hide comment
@sathieu

sathieu Nov 29, 2017

Contributor

and there is no README...

Contributor

sathieu commented Nov 29, 2017

and there is no README...

@unguiculus

This comment has been minimized.

Show comment
Hide comment
@unguiculus

unguiculus Nov 29, 2017

Member

@prydonius Could you check why the chart is not listed?

Member

unguiculus commented Nov 29, 2017

@prydonius Could you check why the chart is not listed?

@geekgonecrazy

This comment has been minimized.

Show comment
Hide comment
@geekgonecrazy

geekgonecrazy Nov 30, 2017

Would be glad to help make what ever changes are needed to make it show up.

Would be glad to help make what ever changes are needed to make it show up.

@sathieu

This comment has been minimized.

Show comment
Hide comment
@sathieu

sathieu Nov 30, 2017

Contributor

Maybe this is the README missing?

Contributor

sathieu commented Nov 30, 2017

Maybe this is the README missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment