Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] cloudbuild failing #2136

Closed
mdbooth opened this issue Feb 28, 2023 · 3 comments · Fixed by #2139
Closed

[all] cloudbuild failing #2136

mdbooth opened this issue Feb 28, 2023 · 3 comments · Fixed by #2139

Comments

@mdbooth
Copy link
Contributor

mdbooth commented Feb 28, 2023

Example: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/cloud-provider-openstack-push-images/1630385626224267264

The immediate cause seems to be an incorrect go version, but as the build method looks highly unusual it is probably simpler to move to a more orthodox build method. Specifically, the docker builds should be self-contained. They currently build a rootfs.tar from the Makefile and copy it into an alpine image.

I suggest copying the structure of a Dockerfile from another project would be simplest. We will likely have to update cloudbuild.yaml afterwards as well.

This impacts #1540

@mdbooth
Copy link
Contributor Author

mdbooth commented Feb 28, 2023

@jichenjc
Copy link
Contributor

jichenjc commented Mar 2, 2023

I assume you are talking about something like following sample?
https://github.com/sustainable-computing-io/kepler/blob/main/build/Dockerfile
like from a base and we build from the base image (to keep the build env stable) ?

anyway, should we consider fix this first issue first to unblock then open another issue to track the build env things?
or you want to fix the build method first ?

@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 2, 2023

I assume you are talking about something like following sample? https://github.com/sustainable-computing-io/kepler/blob/main/build/Dockerfile like from a base and we build from the base image (to keep the build env stable) ?

anyway, should we consider fix this first issue first to unblock then open another issue to track the build env things? or you want to fix the build method first ?

It was going to get messy to fix because we were attempting to build in the test-infra image. I don't think it was intended to be used that way, so they weren't likely to be sympathetic to change requests, and creating our own cloudbuild image would come with its own issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants