This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Bug fix to definition of thenet #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kubernetes/sig-network, could someone review this? |
|
LGTM |
|
Please squash |
When the CNI_COMMAND is DEL, the environment variable `thenet` was being referenced but not defined. Remove unneeded disconnect Updated README.md Added trivial example of bridge network and Flannel. Removed pre-requisite of a multi-host Docker network --- it is not strictly required. A few other minor clarifications.
|
squashed |
|
@bprashanth: squashed, per your request. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the CNI_COMMAND is DEL, the environment variable
thenetwasbeing referenced but not defined.