Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should do next major release #1688

Closed
bryk opened this issue Mar 3, 2017 · 20 comments
Closed

We should do next major release #1688

bryk opened this issue Mar 3, 2017 · 20 comments
Assignees

Comments

@bryk
Copy link
Contributor

bryk commented Mar 3, 2017

We should do next major release and upstream it to latest Kubernetes. This is because we've added a lot of new features recently.

Before we do this, however, we need to validate that there are no half-baked WIP features.

@floreks @maciaszczykm @cheld @ianlewis What WIP is currently blocking the release?

@floreks
Copy link
Member

floreks commented Mar 3, 2017

I guess only thing that is a potential blocker is missing frontend for TPR instances. It should not take long to implement frontend so maybe we could take next week to finish everything and then do a code freeze for features.

@maciaszczykm what do you think?

I should be able to finish implemeting basic support for sorting and maybe filtering next week.

@bryk
Copy link
Contributor Author

bryk commented Mar 3, 2017

Sounds cool. Can you be this release's tzar and make sure we're withing Kubernetes core timelines and schedules? :)

@maciaszczykm
Copy link
Member

missing frontend for TPR instances

I'm only aware of this. Working on finishing backend today and should start it soon. If we want pagination here (in longer run we do) it could take one or two days more.

Next week is realistic estimate for whole work to be finished, then we can work on next iteration :)

@bryk
Copy link
Contributor Author

bryk commented Mar 3, 2017

Next week is realistic estimate for whole work to be finished, then we can work on next iteration :)

Yep. We should do QA before releasing. How about having explicit sign-off from 3-4 folks?

@maciaszczykm
Copy link
Member

@bryk We might be able to do it and for sure we will test on our own. There were few bigger changes like client-go migration or further refactoring and it needs to be checked before release.

@cheld
Copy link
Contributor

cheld commented Mar 3, 2017

There seems to be an issue with latest Hyperkube and kubeadm. 1.6 I had no time to investigate yet.

See also: #1578

@bryk
Copy link
Contributor Author

bryk commented Mar 8, 2017

What's up with TPRs? Are we ready to cut branch? :)

@maciaszczykm
Copy link
Member

@bryk TPRs are in #1695 waiting for review :) Today I'm going to start tests.

@maciaszczykm
Copy link
Member

maciaszczykm commented Mar 8, 2017

We'll align with v1.6.0 release of Kubernetes:
https://github.com/kubernetes/dashboard/milestone/5

@bryk
Copy link
Contributor Author

bryk commented Mar 9, 2017

Awesome. What's totally essential to cut the release? We have only a few days left.

@maciaszczykm
Copy link
Member

maciaszczykm commented Mar 9, 2017

TPRs PR and maybe @floreks' sorting. AFAIK he's already finishing it, but we need to review and test it. We're trying to keep milestone up-to-date.

@maciaszczykm
Copy link
Member

maciaszczykm commented Mar 10, 2017

@bryk Do you know exact date when we need to push release?

@maciaszczykm maciaszczykm added this to the v1.6.0 milestone Mar 13, 2017
@bryk
Copy link
Contributor Author

bryk commented Mar 14, 2017

That's the timeline: https://github.com/kubernetes/features/blob/master/release-1.6/release-1.6.md

We should be fast, but if we miss the deadline, that's not a problem since 1.6.1 will be released soon after.

@bryk
Copy link
Contributor Author

bryk commented Mar 14, 2017

@maciaszczykm Will you craft release notes for our 1.6? When we have this we can push to gcr.io repo (I can do this) and send PRs to customer's repos.

@maciaszczykm
Copy link
Member

@bryk Sure, we'll do it tommorow.

@bryk
Copy link
Contributor Author

bryk commented Mar 15, 2017

I found an issue that v1.6.0 tag does not start on a GKE cluster. Error I get is:

 kubectl logs dash-demo-2-pyqhs
Using HTTP port: 9090
Error while initializing connection to Kubernetes apiserver. This most likely means that the cluster is misconfigured (e.g., it has invalid apiserver certificates or service accounts configuration) or the --apiserver-host param points to a server that does not exist. Reason: invalid configuration: default cluster has no server defined
Refer to the troubleshooting guide for more information: https://github.com/kubernetes/dashboard/blob/master/docs/user-guide/troubleshooting.md

Can you investigate?

@bryk
Copy link
Contributor Author

bryk commented Mar 15, 2017

I updated https://github.com/kubernetes/dashboard/releases/tag/v1.6.0 to DRAFT and pre-release for now.

@bryk
Copy link
Contributor Author

bryk commented Mar 15, 2017

When this is fixed, we must do v1.6.1 when this is fixed

@maciaszczykm
Copy link
Member

Okay, we'll do it as soon as we'll fix client-go-related issue.

@maciaszczykm
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants