Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to enable/disable heapster integration from dashboard #2251

Closed
mccormd opened this issue Aug 10, 2017 · 5 comments · Fixed by #2355
Closed

Add option to enable/disable heapster integration from dashboard #2251

mccormd opened this issue Aug 10, 2017 · 5 comments · Fixed by #2355
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@mccormd
Copy link

mccormd commented Aug 10, 2017

Environment
Dashboard version: 1.6.3
Kubernetes version: 1.7.3
Operating system: CoreOS
Steps to reproduce

When I start the dashboard with the workaround for heapster (it does not work without it): -

      - name: kubernetes-dashboard
        image: gcr.io/google_containers/kubernetes-dashboard-amd64:v1.6.3
        args:
        - --heapster-host=http://heapster.kube-system

If heapster service comes up after the dashboard pods then the dashboard does not display any graphs.

Observed result

Kubernetes dashboard does not retry for heapster availability and so no graphs are displayed within the dashboard.

Forcing a redeployment/killing the dashboard pods once heapster is up brings back the graphs.

Expected result

I don't want to have to start the dashboard after heapster as this is hard to orchestrate.
The dashboard should continue to check for heapster availability and start displaying graphs once it is available rather than checking once.

@floreks
Copy link
Member

floreks commented Aug 10, 2017

We have disabled this option to avoid unnecessary timeouts and checks if heapster is not present during the start. Some people were reporting that if heapster could not be reached it caused major delays in loading dashboard page. It will stay this way until we add settings page with option to enable/disable integrations on-the-fly.

@floreks
Copy link
Member

floreks commented Aug 10, 2017

As for the --heapster-host=http://heapster.kube-system it should not be needed if cluster is working properly. Heapster is automatically discovered by dashboard on start . Only requirement is that heapster service is named heapster and is located in kube-system namespace. We are using then in-cluster communication through kubernetes service proxy.

@floreks floreks added kind/feature Categorizes issue or PR as related to a new feature. priority/P2 labels Aug 10, 2017
@floreks floreks changed the title Heapster needs to be available when dashboard comes up Add option to enable/disable heapster integration from dashboard Aug 10, 2017
@floreks
Copy link
Member

floreks commented Aug 10, 2017

I have changed title so we can keep it as a tracking issue.

@mccormd
Copy link
Author

mccormd commented Aug 15, 2017

Hi, I may have missed the point, sorry, but I don't want a single check for heapster upon start up or a settings page within the dashboard. We bootstrap a number of different kubernetes clusters and so I want the dashboard to come up with heapster integrated graphs reliably, even if the heapster pod has not yet started when the dashboard is loading.

Maybe there could be a command line flag to enable/disable heapster integration or not but when enabled the dashboard should periodically check for heapster availability so that it starts serving the graphs once heapster becomes available. The same mechanism might also be used to prevent attempts to get the graphs if heapster has been tested to be unavailable.

@floreks
Copy link
Member

floreks commented Aug 16, 2017

Ok, I get what you mean. We'll add such feature together with option to enable/disable integrations but currently we have more important issues to work on. Previously on every request we've tried to get heapster metrics without checking if it is present. Due to that some people reported that dashboard loading time increased. For now we've chosen to resolve this issue this way and work on improvements in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants