Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sparklines for node list #3768

Open
jeefy opened this issue Apr 28, 2019 · 8 comments
Open

Add sparklines for node list #3768

jeefy opened this issue Apr 28, 2019 · 8 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@jeefy
Copy link
Member

jeefy commented Apr 28, 2019

Dashboard does not display metrics for nodes. This should be fairly easy to add, basing things off of the code used for Pods.

@jeefy jeefy added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 28, 2019
@jeefy jeefy added this to the v2.0.0 milestone Apr 28, 2019
@feloy
Copy link
Member

feloy commented May 5, 2019

@jeefy Which metrics precisely would you like to be displayed?

@jeefy
Copy link
Member Author

jeefy commented May 8, 2019

CPU / Memory are the two that are collected. :)

@shu-mutou
Copy link
Contributor

@jeefy Pie charts for CPUs and memory of kind-0.2.1 cluster are shown in my dashboard like below. Are these pie charts what you want?
Screenshot from 2019-05-14 16-55-45

@jeefy
Copy link
Member Author

jeefy commented May 16, 2019

I was thinking we could show the same sparklines that we display for Pod metrics. Thoughts?

@shu-mutou
Copy link
Contributor

Now, I understand what you wants. I found NodeList object has "CumulativeMetrics", but it seems to be cpu/memory history for all of nodes, rather than for each node.
If we can get cpu/memory history for each node independently, we would able to add columns for sparklines into "Nodes" table, I think.
Do you know the other way to get cpu/memory history for each nodes?

@maciaszczykm maciaszczykm changed the title Node List does not display metrics graphs Add sparklines for node list Jun 6, 2019
@maciaszczykm maciaszczykm removed this from the v2.0.0 milestone Jun 11, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2019
@maciaszczykm
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 9, 2019
@anshulahuja98
Copy link
Contributor

anshulahuja98 commented Sep 11, 2019

@jeefy
Has it been finalized as to what exactly is required in this issue?
I would like to work on it
Would appreciate if anyone could guide a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

7 participants