Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in the readme #581

Closed
rafalkrupinski opened this issue Mar 15, 2023 · 3 comments · Fixed by #583
Closed

Broken link in the readme #581

rafalkrupinski opened this issue Mar 15, 2023 · 3 comments · Fixed by #583
Assignees
@kundan2707
Labels
kind/documentation Categorizes issue or PR as related to documentation.

Comments

@rafalkrupinski
Copy link

dns/README.md

Line 7 in 5b640bb

This is the repository for [Kubernetes DNS](http://kubernetes.io/docs/admin/dns/).

The link https://kubernetes.io/docs/admin/dns/ returns 404 not found, althou it's neatly hidden in the tab title.

I guess this link would be valid, but someone please check.
@dpasiukevich
Copy link
Member

Thanks for spotting that!

The suggested link LGTM.
I'd only update the link text to be [Kubernetes DNS (kube-dns and nodelocaldns)](...link here...)

@rafalkrupinski would it be ok for you to make a small PR for that?

@kundan2707
Copy link
Contributor

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 31, 2023
@kundan2707
Copy link
Contributor

/assign

@kundan2707 kundan2707 mentioned this issue Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kundan2707 kundan2707

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrected link for external dns kundan2707/dns
4 participants
@rafalkrupinski @dpasiukevich @k8s-ci-robot @kundan2707