DNS flag kube-master-url is not respected

[dkoshkin]

Using gcr.io/google_containers/k8s-dns-kube-dns-amd64:1.14.1
K8s: v1.6.0-beta.4

Looks like the value in the kubeconfig overrides the value provided in kube-master-url flag. The dns pod doesn't start up.

Settings the flags below when starting the DNS pod

- --kubecfg-file=/root/.kube/config
- --kube-master-url=https://34.205.140.27:6443

kube config content

apiVersion: v1
kind: Config
clusters:
- name: kubernetes
  cluster:
    certificate-authority: /etc/kubernetes/ca.pem
    server: "https://127.0.0.1:6443"
users:
- name: admin
  user:
    username: admin
    password: "abbazabba"
contexts:
- name: kubernetes
  context:
    cluster: kubernetes
    user: admin
current-context: kubernetes

[root@ip-10-0-3-130 specs]# docker logs e919ff944998
I0327 23:42:02.206667       1 dns.go:49] version: v1.5.2-beta.0+$Format:%h$
I0327 23:42:02.230408       1 server.go:74] ConfigMap and ConfigDir not configured, using values from command line flags
I0327 23:42:02.230455       1 server.go:112] FLAG: --alsologtostderr="false"
I0327 23:42:02.230480       1 server.go:112] FLAG: --config-dir=""
I0327 23:42:02.230485       1 server.go:112] FLAG: --config-map=""
I0327 23:42:02.230488       1 server.go:112] FLAG: --config-map-namespace="kube-system"
I0327 23:42:02.230492       1 server.go:112] FLAG: --config-period="10s"
I0327 23:42:02.230497       1 server.go:112] FLAG: --dns-bind-address="0.0.0.0"
I0327 23:42:02.230500       1 server.go:112] FLAG: --dns-port="10053"
I0327 23:42:02.230506       1 server.go:112] FLAG: --domain="cluster.local."
I0327 23:42:02.230514       1 server.go:112] FLAG: --federations=""
I0327 23:42:02.230519       1 server.go:112] FLAG: --healthz-port="8081"
I0327 23:42:02.230522       1 server.go:112] FLAG: --initial-sync-timeout="1m0s"
I0327 23:42:02.230525       1 server.go:112] FLAG: --kube-master-url="https://34.205.140.27:6443"
I0327 23:42:02.230530       1 server.go:112] FLAG: --kubecfg-file="/root/.kube/config"
I0327 23:42:02.230533       1 server.go:112] FLAG: --log-backtrace-at=":0"
I0327 23:42:02.230538       1 server.go:112] FLAG: --log-dir=""
I0327 23:42:02.230543       1 server.go:112] FLAG: --log-flush-frequency="5s"
I0327 23:42:02.230546       1 server.go:112] FLAG: --logtostderr="true"
I0327 23:42:02.230550       1 server.go:112] FLAG: --nameservers=""
I0327 23:42:02.230552       1 server.go:112] FLAG: --stderrthreshold="2"
I0327 23:42:02.230556       1 server.go:112] FLAG: --v="2"
I0327 23:42:02.230559       1 server.go:112] FLAG: --version="false"
I0327 23:42:02.230564       1 server.go:112] FLAG: --vmodule=""
I0327 23:42:02.230610       1 server.go:175] Starting SkyDNS server (0.0.0.0:10053)
I0327 23:42:02.230722       1 server.go:199] Skydns metrics not enabled
I0327 23:42:02.230732       1 dns.go:147] Starting endpointsController
I0327 23:42:02.230735       1 dns.go:150] Starting serviceController
I0327 23:42:02.231403       1 logs.go:41] skydns: ready for queries on cluster.local. for tcp://0.0.0.0:10053 [rcache 0]
I0327 23:42:02.231421       1 logs.go:41] skydns: ready for queries on cluster.local. for udp://0.0.0.0:10053 [rcache 0]
E0327 23:42:02.231652       1 reflector.go:199] k8s.io/dns/vendor/k8s.io/client-go/tools/cache/reflector.go:94: Failed to list *v1.Endpoints: Get https://127.0.0.1:6443/api/v1/endpoints?resourceVersion=0: dial tcp 127.0.0.1:6443: getsockopt: connection refused
E0327 23:42:02.231698       1 reflector.go:199] k8s.io/dns/vendor/k8s.io/client-go/tools/cache/reflector.go:94: Failed to list *v1.Service: Get https://127.0.0.1:6443/api/v1/services?resourceVersion=0: dial tcp 127.0.0.1:6443: getsockopt: connection refused
I0327 23:42:02.731122       1 dns.go:174] DNS server not ready, retry in 500 milliseconds
I0327 23:42:03.230954       1 dns.go:174] DNS server not ready, retry in 500 milliseconds

[MrHohn]

Seems to be a regression unintentionally introduced by commit ffb9039.

[tuminoid]

I don't have kubeconfig in my test setup and I hit this, so rather than being overridden by kubeconfig, it is just not respected at all.