-
Notifications
You must be signed in to change notification settings - Fork 1.4k
/
approval.go
133 lines (105 loc) · 3.23 KB
/
approval.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
/*
Copyright 2021 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package kepval
import (
"fmt"
"os"
"path/filepath"
"strings"
"github.com/blang/semver/v4"
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
"k8s.io/enhancements/api"
)
func ValidatePRR(kep *api.Proposal, h *api.PRRHandler, prrDir string) error {
requiredPRRApproval, err := isPRRRequired(kep)
if err != nil {
return errors.Wrap(err, "checking if PRR is required")
}
if !requiredPRRApproval {
logrus.Debugf("PRR review is not required for %s", kep.Number)
return nil
}
prrFilename := kep.Number + ".yaml"
prrFilepath := filepath.Join(
prrDir,
kep.OwningSIG,
prrFilename,
)
logrus.Infof("PRR file: %s", prrFilepath)
prrFile, err := os.Open(prrFilepath)
if os.IsNotExist(err) {
return err
}
if err != nil {
return errors.Wrapf(err, "could not open file %s", prrFilepath)
}
// TODO: Create a context to hold the parsers
prr, prrParseErr := h.Parse(prrFile)
if prrParseErr != nil {
return errors.Wrap(prrParseErr, "parsing PRR approval file")
}
// TODO: This shouldn't be required once we push the errors into the
// parser struct
if prr.Error != nil {
return errors.Wrapf(prr.Error, "%v has an error", prrFilepath)
}
stagePRRApprover, err := prr.ApproverForStage(kep.Stage)
if err != nil {
return errors.Wrapf(err, "getting PRR approver for %s stage", kep.Stage)
}
if stagePRRApprover == "" {
return errors.New("PRR approver cannot be empty")
}
if strings.HasPrefix(stagePRRApprover, "@") {
stagePRRApprover = strings.TrimPrefix(stagePRRApprover, "@")
}
validApprover := api.IsOneOf(stagePRRApprover, h.PRRApprovers)
if !validApprover {
return errors.New(
fmt.Sprintf(
"this contributor (%s) is not a PRR approver (%v)",
stagePRRApprover,
h.PRRApprovers,
),
)
}
return nil
}
func isPRRRequired(kep *api.Proposal) (required bool, err error) {
logrus.Debug("checking if PRR is required")
required = kep.Status == api.ImplementableStatus || kep.Status == api.ImplementedStatus
if !required {
return false, nil
}
if kep.IsMissingMilestone() {
return required, fmt.Errorf("missing the latest milestone field: %s", kep.Filename)
}
if kep.IsMissingStage() {
return required, fmt.Errorf("missing the stage field: %s", kep.Filename)
}
// TODO: Consider making this a function
prrRequiredAtSemVer, err := semver.ParseTolerant("v1.21")
if err != nil {
return required, errors.Wrap(err, "creating a SemVer object for PRRs")
}
latestSemVer, err := semver.ParseTolerant(kep.LatestMilestone)
if err != nil {
return required, errors.Wrap(err, "creating a SemVer object for latest milestone")
}
if latestSemVer.LT(prrRequiredAtSemVer) {
required = false
return required, nil
}
return required, nil
}