Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid serializing the same object independently for every watcher #1152

Closed
wojtek-t opened this issue Jul 19, 2019 · 12 comments
Closed

Avoid serializing the same object independently for every watcher #1152

wojtek-t opened this issue Jul 19, 2019 · 12 comments
Assignees
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@wojtek-t
Copy link
Member

wojtek-t commented Jul 19, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Avoid serializing the same object independently for every watcher.
  • Kubernetes Enhancement Proposal: KEP
  • Primary contact (assignee): wojtek-t
  • Responsible SIGs: sig-apimachinery, sig-scalability
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.16)
    • Beta release target (1.17)
    • Stable release target (1.18)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@wojtek-t wojtek-t added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 19, 2019
@wojtek-t wojtek-t self-assigned this Jul 19, 2019
@wojtek-t wojtek-t added this to the v1.16 milestone Jul 23, 2019
@wojtek-t wojtek-t modified the milestones: v1.16, v1.17 Sep 12, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 23, 2019

Hey there @wojtek-t -- 1.17 Enhancements lead here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Sep 23, 2019
@wojtek-t
Copy link
Member Author

wojtek-t commented Sep 24, 2019

Yes - this is planned for 1.17

@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 24, 2019

Great. I'll add it to the tracking sheet 👍

@mrbobbytables mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 24, 2019
@wojtek-t
Copy link
Member Author

wojtek-t commented Oct 1, 2019

Given it's not a feature per-se (this is implementation detail, the change is invisible to use), this will go directly to GA. Changing the stage.

@wojtek-t wojtek-t added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Oct 1, 2019
@wojtek-t
Copy link
Member Author

wojtek-t commented Oct 22, 2019

We're already code-complete for that. And given it's purely implementational change, it doesn't require any docs.
Which mean that we seem to be completely done with it.

@mrbobbytables
Copy link
Member

mrbobbytables commented Oct 22, 2019

Nice! Just for accounting purposes, was this the primary PR?
kubernetes/kubernetes#81914

@wojtek-t
Copy link
Member Author

wojtek-t commented Oct 23, 2019

Yes - kubernetes/kubernetes#81914 is the main one.
kubernetes/kubernetes#84043 is some minor improvement on top of it.

@daminisatya
Copy link
Member

daminisatya commented Oct 30, 2019

Hello @wojtek-t I'm 1.17 docs lead.

Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@wojtek-t
Copy link
Member Author

wojtek-t commented Oct 30, 2019

See the comment above (my second last comment):

We're already code-complete for that. And given it's purely implementational change, it doesn't require any docs.
Which mean that we seem to be completely done with it.

@daminisatya
Copy link
Member

daminisatya commented Oct 30, 2019

Awesome! Thank you @wojtek-t

@wojtek-t
Copy link
Member Author

wojtek-t commented Dec 10, 2019

This KEP has been implemented and released in 1.17. Closing.

@jeremyrickard jeremyrickard removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 3, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 17, 2020

/remove-milestone v1.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

5 participants