Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-4603: Tune CrashLoopBackoff #4603

Open
1 of 4 tasks
lauralorenz opened this issue Apr 30, 2024 · 17 comments
Open
1 of 4 tasks

KEP-4603: Tune CrashLoopBackoff #4603

lauralorenz opened this issue Apr 30, 2024 · 17 comments
Assignees
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Milestone

Comments

@lauralorenz
Copy link
Contributor

lauralorenz commented Apr 30, 2024

Enhancement Description

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 30, 2024
@lauralorenz lauralorenz changed the title KEP-TBD: Tune CrashLoopBackoff KEP-4603: Tune CrashLoopBackoff Apr 30, 2024
@SergeyKanzhelev
Copy link
Member

/label lead-opted-in
/milestone v1.31
/assign @lauralorenz

@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 23, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label May 23, 2024
@SergeyKanzhelev
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 24, 2024
@SergeyKanzhelev
Copy link
Member

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label May 24, 2024
@mickeyboxell
Copy link

mickeyboxell commented Jun 4, 2024

Hi @lauralorenz 👋 v1.31 Enhancements team here.

I wanted to check in as we approach the enhancements freeze on 02:00 UTC Friday 14th June 2024 / 19:00 PDT Thursday 13th June 2024.

This enhancement is targeting alpha for v1.31. Please correct me if that isn't the case.

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.31. KEPs targeting stable will need to be marked as implemented after code PRs are merged and the feature gates are removed.
  • KEP readme has up-to-date graduation criteria
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline so that the PRR team has enough time to review your KEP before the enhancements freeze.

For this KEP, we need to do the following:

The status of this enhancement is marked as at risk for enhancement freeze. We can mark it as tracked as soon as the above changes are merged. Please make sure to get this done before the enhancements freeze.

If you anticipate missing enhancements freeze, you can file an exception request in advance. Let me know if you have any questions! Thank you!

@mickeyboxell
Copy link

Hi @lauralorenz, I wanted to follow up again prior to the enhancements freeze tomorrow. Do you think you'll have some time today or tomorrow to address the comments above?

@lauralorenz
Copy link
Contributor Author

Thanks for following up @mickeyboxell! This is going to get bumped to 1.32. You can take it off your radar. Thanks!

@dipesh-rawat
Copy link
Member

Hello @lauralorenz 👋, 1.31 Enhancements team here.

Since this enhancement has been rescheduled for a future release, it’s now marked as Deferred for the current v1.31 release cycle. Confirming this based on the comment #4603 (comment). Thanks!

/milestone clear
/remove-label lead-opted-in

@k8s-ci-robot
Copy link
Contributor

@dipesh-rawat: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

Hello @lauralorenz 👋, 1.31 Enhancements team here.

Since this enhancement has been rescheduled for a future release, it’s now marked as Deferred for the current v1.31 release cycle. Confirming this based on the comment #4603 (comment). Thanks!

/milestone clear
/remove-label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed the lead-opted-in Denotes that an issue has been opted in to a release label Jun 13, 2024
@SergeyKanzhelev
Copy link
Member

/milestone clear
/remove-label lead-opted-in

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: Those labels are not set on the issue: lead-opted-in

In response to this:

/milestone clear
/remove-label lead-opted-in

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot removed this from the v1.31 milestone Jun 13, 2024
@sreeram-venkitesh
Copy link
Member

/label tracked/no

@k8s-ci-robot k8s-ci-robot added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jun 24, 2024
@kannon92
Copy link
Contributor

@lauralorenz @tallclair wdyt of kubernetes/kubernetes#122300? I think having a max limit on back off and then setting pod to failed would be useful and I’m curious if we can expand this feature.

@lauralorenz
Copy link
Contributor Author

Hi! Commented over there at kubernetes/kubernetes#122300 (comment)

@haircommander
Copy link
Contributor

/milestone v1.32
/label lead-opted-in

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added the lead-opted-in Denotes that an issue has been opted in to a release label Sep 17, 2024
@impact-maker
Copy link
Member

impact-maker commented Sep 29, 2024

Hello @haircommander @lauralorenz 👋, v1.32 Enhancements team here.

Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024.

This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise).

Here's where this enhancement currently stands:

  • KEP readme using the latest template has been merged into the k/enhancements repo.
  • KEP status is marked as implementable for latest-milestone: v1.32.
  • KEP readme has up-to-date graduation criteria.
  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

For this KEP, we would need to update the following:

  • KEP has submitted a production readiness review request for approval and has a reviewer assigned.
  • KEP has a production readiness review that has been completed and merged into k/enhancements. (For more information on the PRR process, check here). If your production readiness review is not completed yet, please make sure to fill the production readiness questionnaire in your KEP by the PRR Freeze deadline on Thursday 3rd October 2024 so that the PRR team has enough time to review your KEP.

The status of this enhancement is marked as at risk for enhancement freeze. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you!

@impact-maker
Copy link
Member

@lauralorenz thanks! Everything looks good, I have updated the issue status to tracked for enhancements freeze

@chanieljdan
Copy link

Hi @lauralorenz 👋, 1.32 Release Docs Lead here.

Does this enhancement work planned for 1.32 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT.

Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.

Thank you!

@liggitt liggitt added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lead-opted-in Denotes that an issue has been opted in to a release sig/node Categorizes an issue or PR as relevant to SIG Node. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team
Projects
Status: Tracked for enhancements freeze
Status: Tracked
Status: Deferred
Development

No branches or pull requests