Skip to content

Commit

Permalink
fix signatures
Browse files Browse the repository at this point in the history
  • Loading branch information
Federico Gimenez committed Nov 29, 2017
1 parent 81eaf2f commit 93bce13
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions pkg/tiller/release_modules.go
Expand Up @@ -159,9 +159,9 @@ func DeleteRelease(rel *release.Release, vs chartutil.VersionSet, kubeClient env
return rel.Manifest, []error{fmt.Errorf("corrupted release record. You must manually delete the resources: %s", err)}
}

filesToKeep, filesToDelete := filterManifestsToKeep(files, kubeClient, rel.Namespace)
filesToKeep, filesToDelete := filterManifestsToKeep(files)
if len(filesToKeep) > 0 {
kept = summarizeKeptManifests(filesToKeep)
kept = summarizeKeptManifests(filesToKeep, kubeClient, rel.Namespace)
}

errs = []error{}
Expand Down
4 changes: 2 additions & 2 deletions pkg/tiller/resource_policy.go
Expand Up @@ -33,7 +33,7 @@ const resourcePolicyAnno = "helm.sh/resource-policy"
// during an uninstallRelease action.
const keepPolicy = "keep"

func filterManifestsToKeep(manifests []Manifest, kubeClient environment.KubeClient, namespace string) ([]Manifest, []Manifest) {
func filterManifestsToKeep(manifests []Manifest) ([]Manifest, []Manifest) {
remaining := []Manifest{}
keep := []Manifest{}

Expand All @@ -58,7 +58,7 @@ func filterManifestsToKeep(manifests []Manifest, kubeClient environment.KubeClie
return keep, remaining
}

func summarizeKeptManifests(manifests []Manifest) string {
func summarizeKeptManifests(manifests []Manifest, kubeClient environment.KubeClient, namespace string) string {
message := "These resources were kept due to the resource policy:\n"
for _, m := range manifests {
// check if m is in fact present from k8s client's POV.
Expand Down

0 comments on commit 93bce13

Please sign in to comment.