-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--set option not parsing as boolean #1449
Comments
I suggest going through options passed through set with the strconv package (ignoring any errors and falling back to a string). The question is, should we just try to parse booleans or integers also? Order also becomes important, because 1 and 0 can be parsed as booleans. |
michelleN
pushed a commit
to michelleN/helm
that referenced
this issue
Oct 24, 2016
michelleN
pushed a commit
to michelleN/helm
that referenced
this issue
Oct 25, 2016
michelleN
pushed a commit
to michelleN/helm
that referenced
this issue
Oct 25, 2016
MichaelMorrisEst
pushed a commit
to Nordix/helm
that referenced
this issue
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Original issue is on the kubernetes/charts repo: helm/charts#138
The output of the manifest and computed values is correct, however, a conditional in the template to create a PVC is not being parsed correctly because it creates the PVC even if I set the value of persistence.enabled to false on the command line using the --set flag.
The text was updated successfully, but these errors were encountered: