Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--set option not parsing as boolean #1449

Closed
michelleN opened this issue Oct 24, 2016 · 1 comment · Fixed by #1451
Closed

--set option not parsing as boolean #1449

michelleN opened this issue Oct 24, 2016 · 1 comment · Fixed by #1451

Comments

@michelleN
Copy link
Member

michelleN commented Oct 24, 2016

Original issue is on the kubernetes/charts repo: helm/charts#138

The output of the manifest and computed values is correct, however, a conditional in the template to create a PVC is not being parsed correctly because it creates the PVC even if I set the value of persistence.enabled to false on the command line using the --set flag.

$ helm version
Client: &version.Version{SemVer:"v2.0.0-beta.1", GitCommit:"58be8c9fce50f0657425443b83307ba91789b794", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.0.0-beta.1", GitCommit:"05c04bccae63c6392ec0cb0e27790650167279f0", GitTreeState:"clean"}
@prydonius
Copy link
Member

I suggest going through options passed through set with the strconv package (ignoring any errors and falling back to a string). The question is, should we just try to parse booleans or integers also? Order also becomes important, because 1 and 0 can be parsed as booleans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants