Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiller net=host #2222

Closed
kfox1111 opened this issue Apr 5, 2017 · 14 comments
Closed

tiller net=host #2222

kfox1111 opened this issue Apr 5, 2017 · 14 comments

Comments

@kfox1111
Copy link

kfox1111 commented Apr 5, 2017

I'd like to use helm to deploy sdn plugins such as canal, calico or weave. This would allow much more easily configured sdn's due to helms templating engine. To do so, requires tiller to be running before the sdn.

Due to the way helm contacts tiller via proxy without using a svc, This seems to work by simply by launching tiller's pod with net=host.

Can support for that be added as a command line flag to helm init?

@technosophos
Copy link
Member

That seems like an option we should be able to add easily.

jascott1 added a commit to jascott1/helm that referenced this issue Apr 13, 2017
When 'helm init --net-host=true' is run, Tiller will be installed with access to the host network (net=host in Docker)

Closes helm#2222
jascott1 added a commit to jascott1/helm that referenced this issue Apr 13, 2017
When 'helm init --net-host=true' is run, Tiller will be installed with access to the host network (net=host in Docker)

Closes helm#2222
@jascott1
Copy link
Contributor

@kfox1111
Copy link
Author

This works good. Thank you. :)

@jascott1
Copy link
Contributor

@technosophos afaik if we want this in, we just need to decide on final flag name and description.
It is currently:

--host-net                 install tiller with net=host

@kfox1111
Copy link
Author

I have a slight preference to --net-host instead of --host-net, as its closer to whats in docker. but doesn't matter too much.

One question would be when this would merge. If its going in to 2.3.1, I think its probably fine as is.

If its going to wait for 2.4.0, then maybe we should ask the question, should it be defaulted on, and can be turned off rather then off and defaulted on? --net-sdn or something.

Switching the default would be simpler for those wanting to deploy sdn and other low level things out of the box and I think should still work for everyone still.

@rothgar
Copy link

rothgar commented Apr 14, 2017

I believe this would also get around the problem of not having socat on nodes running kubelet. Maybe I'm wrong but I can test in my cluster.

@jascott1
Copy link
Contributor

@kfox1111 i agree --net-host is better. I got it backwards myself telling someone so i think --net-host is more intuitive.

@kfox1111
Copy link
Author

@jascott1 a couple of other issues found while testing this:

could the following toleration be added:
node-role.kubernetes.io/master=:NoSchedule

and, some way to add nodeSelector's so tiller can be targeted to specific hosts rather then floating around the cluster. helm init -n key=value? Its kind of unrelated to this PR, but touches the same code.

@jascott1
Copy link
Contributor

@kfox1111 So we want a switch to add that toleration or just use the key/value pattern like you suggested for nodeSelectors?

@kfox1111
Copy link
Author

hmm... a switch maybe? --on-master?

@kfox1111
Copy link
Author

or I guess it could be a switch. --tolerations key=value. a little harder to use, but very generic.

@jascott1
Copy link
Contributor

We should probably go for --tolerations and --node-selectors

@kfox1111
Copy link
Author

Sounds good to me. :)

@jascott1
Copy link
Contributor

@technosophos Sounds good?

jascott1 added a commit to jascott1/helm that referenced this issue Apr 18, 2017
When 'helm init --net-host=true' is run, Tiller will be installed with access to the host network (net=host in Docker)

Closes helm#2222
jascott1 added a commit to jascott1/helm that referenced this issue Apr 18, 2017
When 'helm init --net-host=true' is run, Tiller will be installed with access to the host network (net=host in Docker)

Closes helm#2222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants