Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name-template flag for installation that allows the user to speci… #1015

Merged
merged 2 commits into from Aug 3, 2016

Conversation

vaikas
Copy link

@vaikas vaikas commented Aug 2, 2016

…fy a template used for release name generation

If I understood the issue correctly, something like this?
#975

…fy a template used for release name generation
"fmt"
"io"
"io/ioutil"
"os"
"path/filepath"
"strings"

"html/template"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want text/template, though I'm not sure that it will make a difference in this case.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to switch to it and it doesn't work with the funcmaps. But, asides from that, is this roughly what you had in mind for the feature?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah... you have to use sprig.TxtFuncMap(). Forgot about that.

Otherwise, yes, this is exactly what I had in mind.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, great. That works. Thanks, PTAL.

@vaikas
Copy link
Author

vaikas commented Aug 3, 2016

@viglesiasce Could you take a look and see if this would help your use case?

@technosophos
Copy link
Member

Manual testing:

$  helm install --name-template "technosophos-{{randAlpha 6 | lower}}" docs/examples/alpine
final name: technosophos-hxaawt
technosophos-hxaawt

I think we could remove final-name: YYY from the output, but it all works exactly as envisioned.

@vaikas
Copy link
Author

vaikas commented Aug 3, 2016

Thanks!!! Vic, did I misunderstand how you wanted the name output format to look. I can remove the final name but just lmk. If I don't hear soon, I'll just submit and we can omit it later.

@vaikas vaikas merged commit 1d718d7 into helm:master Aug 3, 2016
@viglesiasce
Copy link
Contributor

Hey @vaikas-google! Sorry for the late response. Yeah I'd prefer either:

  1. Just the derived app name
  2. A way to configure what output format comes out json, yaml, simple (default like 1 above)

Maybe I can use this as my first PR attempt.

MichaelMorrisEst pushed a commit to Nordix/helm that referenced this pull request Nov 17, 2023
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 2 to 3.
- [Release notes](https://github.com/docker/setup-qemu-action/releases)
- [Commits](docker/setup-qemu-action@v2...v3)

---
updated-dependencies:
- dependency-name: docker/setup-qemu-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants