New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add name-template flag for installation that allows the user to speci… #1015
Conversation
…fy a template used for release name generation
"fmt" | ||
"io" | ||
"io/ioutil" | ||
"os" | ||
"path/filepath" | ||
"strings" | ||
|
||
"html/template" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want text/template
, though I'm not sure that it will make a difference in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to switch to it and it doesn't work with the funcmaps. But, asides from that, is this roughly what you had in mind for the feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeah... you have to use sprig.TxtFuncMap()
. Forgot about that.
Otherwise, yes, this is exactly what I had in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, great. That works. Thanks, PTAL.
@viglesiasce Could you take a look and see if this would help your use case? |
Manual testing: $ helm install --name-template "technosophos-{{randAlpha 6 | lower}}" docs/examples/alpine
final name: technosophos-hxaawt
technosophos-hxaawt I think we could remove |
Thanks!!! Vic, did I misunderstand how you wanted the name output format to look. I can remove the final name but just lmk. If I don't hear soon, I'll just submit and we can omit it later. |
Hey @vaikas-google! Sorry for the late response. Yeah I'd prefer either:
Maybe I can use this as my first PR attempt. |
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 2 to 3. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](docker/setup-qemu-action@v2...v3) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…fy a template used for release name generation
If I understood the issue correctly, something like this?
#975