Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiller_fix_2261 #2262

Merged
merged 5 commits into from Apr 12, 2017
Merged

tiller_fix_2261 #2262

merged 5 commits into from Apr 12, 2017

Conversation

sbezverk
Copy link
Contributor

Double a size of maximum message to accommodate a very large/complex charts.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2017
@technosophos
Copy link
Member

Closes #2261

Copy link
Member

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and it works. Raising the limit here makes it more likely that we'll hit Kubernetes' built-in limit on ConfigMap sizes. But I had to specially craft a chart to get that error:

$ helm upgrade prodding-lamb .
Error: UPGRADE FAILED: ConfigMap "prodding-lamb.v2" is invalid: data: Too long: must have at most 1048576 characters

(To do the above, I had to to add a file populated from /dev/random to work against the compression efficiency of gzip.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants