-
Notifications
You must be signed in to change notification settings - Fork 296
/
validator.go
442 lines (389 loc) · 12.8 KB
/
validator.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
/*
Copyright 2018 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package fuzz
import (
"context"
"crypto/tls"
"fmt"
"io"
"net/http"
"strings"
"sync"
"time"
"github.com/GoogleCloudPlatform/k8s-cloud-provider/pkg/cloud"
"github.com/google/go-cmp/cmp"
v1 "k8s.io/api/core/v1"
networkingv1 "k8s.io/api/networking/v1"
"k8s.io/ingress-gce/pkg/annotations"
backendconfig "k8s.io/ingress-gce/pkg/apis/backendconfig/v1"
frontendconfig "k8s.io/ingress-gce/pkg/apis/frontendconfig/v1beta1"
"k8s.io/ingress-gce/pkg/utils/common"
"k8s.io/ingress-gce/pkg/utils/namer"
"k8s.io/klog/v2"
)
// pathForDefaultBackend is a unique string that will not match any path.
const pathForDefaultBackend = "/edeaaff3f1774ad2888673770c6d64097e391bc362d7d6fb34982ddf0efd18cb"
// ValidatorEnv captures non-Ingress spec related environment that affect the
// set of validations and Features.
type ValidatorEnv interface {
BackendConfigs() (map[string]*backendconfig.BackendConfig, error)
FrontendConfigs() (map[string]*frontendconfig.FrontendConfig, error)
Services() (map[string]*v1.Service, error)
Cloud() cloud.Cloud
BackendNamer() namer.BackendNamer
FrontendNamerFactory() namer.IngressFrontendNamerFactory
}
// MockValidatorEnv is an environment that is used for mock testing.
type MockValidatorEnv struct {
BackendConfigsMap map[string]*backendconfig.BackendConfig
FrontendConfigMap map[string]*frontendconfig.FrontendConfig
ServicesMap map[string]*v1.Service
MockCloud *cloud.MockGCE
IngressNamer *namer.Namer
frontendNamerFactory namer.IngressFrontendNamerFactory
}
// BackendConfigs implements ValidatorEnv.
func (e *MockValidatorEnv) BackendConfigs() (map[string]*backendconfig.BackendConfig, error) {
return e.BackendConfigsMap, nil
}
// FrontendConfigs implements ValidatorEnv.
func (e *MockValidatorEnv) FrontendConfigs() (map[string]*frontendconfig.FrontendConfig, error) {
return e.FrontendConfigMap, nil
}
// Services implements ValidatorEnv.
func (e *MockValidatorEnv) Services() (map[string]*v1.Service, error) {
return e.ServicesMap, nil
}
// Cloud implements ValidatorEnv.
func (e *MockValidatorEnv) Cloud() cloud.Cloud {
return e.MockCloud
}
// Namer implements ValidatorEnv.
func (e *MockValidatorEnv) BackendNamer() namer.BackendNamer {
return e.IngressNamer
}
// FrontendNamerFactory implements ValidatorEnv.
func (e *MockValidatorEnv) FrontendNamerFactory() namer.IngressFrontendNamerFactory {
return e.frontendNamerFactory
}
// IngressValidatorAttributes are derived attributes governing how the Ingress
// is validated. Features will use this structure to express changes to the
// standard checks by modifying this struct.
type IngressValidatorAttributes struct {
CheckHTTP bool
CheckHTTPS bool
RejectInsecureCerts bool
RequestTimeout time.Duration
Region string
// HTTPPort and HTTPSPort are used only for unit testing.
HTTPPort int
HTTPSPort int
}
func (a *IngressValidatorAttributes) equal(b *IngressValidatorAttributes) bool {
return *a == *b
}
func (a *IngressValidatorAttributes) clone() *IngressValidatorAttributes {
var ret IngressValidatorAttributes
ret = *a
return &ret
}
func (a *IngressValidatorAttributes) schemes() []string {
var ret []string
if a.CheckHTTP {
ret = append(ret, "http")
}
if a.CheckHTTPS {
ret = append(ret, "https")
}
return ret
}
// baseAttributes apply settings for the vanilla Ingress spec.
func (a *IngressValidatorAttributes) baseAttributes(ing *networkingv1.Ingress) {
// Check HTTP endpoint only if its enabled.
if annotations.FromIngress(ing).AllowHTTP() {
a.CheckHTTP = true
} else {
a.CheckHTTP = false
}
if len(ing.Spec.TLS) != 0 {
a.CheckHTTPS = true
}
}
// applyFeatures applies the settings for each of the additional features.
func (a *IngressValidatorAttributes) applyFeatures(env ValidatorEnv, ing *networkingv1.Ingress, features []FeatureValidator) error {
for _, f := range features {
klog.V(4).Infof("Applying feature %q", f.Name())
if err := f.ConfigureAttributes(env, ing, a); err != nil {
klog.Warningf("Feature %q could not be applied: %v", f.Name(), err)
return err
}
}
// Try to configure attributes again; no additional changes should occur.
// If changes are detected, one of the features as written is not
// commutative and should be fixed.
copy := a.clone()
for _, f := range features {
if err := f.ConfigureAttributes(env, ing, copy); err != nil {
return err
}
if !a.equal(copy) {
klog.Errorf("Feature %q is unstable generating attributes, %+v becomes %+v", f.Name(), *a, *copy)
return fmt.Errorf("feature %q is unstable generating attributes, %+v becomes %+v", f.Name(), *a, *copy)
}
}
return nil
}
// IngressResult is the result of an Ingress validation.
type IngressResult struct {
Err error
Paths []*PathResult
}
// PathResult is the result of validating a path.
type PathResult struct {
Scheme string
Host string
Path string
Err error
}
// DefaultAttributes are the base attributes for validation.
func DefaultAttributes() *IngressValidatorAttributes {
return &IngressValidatorAttributes{
CheckHTTP: true,
CheckHTTPS: false,
HTTPPort: 80,
HTTPSPort: 443,
RequestTimeout: 1 * time.Second,
}
}
// NewIngressValidator returns a new validator for checking the correctness of
// an Ingress spec against the behavior of the instantiated load balancer.
// If attribs is nil, then the default set of attributes will be used.
func NewIngressValidator(env ValidatorEnv, ing *networkingv1.Ingress, fc *frontendconfig.FrontendConfig, whiteboxTests []WhiteboxTest, attribs *IngressValidatorAttributes, features []Feature) (*IngressValidator, error) {
var fvs []FeatureValidator
for _, f := range features {
fvs = append(fvs, f.NewValidator())
}
if attribs == nil {
attribs = DefaultAttributes()
}
attribs.baseAttributes(ing)
if err := attribs.applyFeatures(env, ing, fvs); err != nil {
return nil, err
}
client := &http.Client{
Transport: &http.Transport{
TLSClientConfig: &tls.Config{InsecureSkipVerify: true},
},
CheckRedirect: func(req *http.Request, via []*http.Request) error {
return http.ErrUseLastResponse
},
}
frontendNamer := env.FrontendNamerFactory().Namer(ing)
return &IngressValidator{
ing: ing,
fc: fc,
frontendNamer: frontendNamer,
features: fvs,
whiteboxTests: whiteboxTests,
attribs: attribs,
client: client,
}, nil
}
// IngressValidator encapsulates the logic required to validate a given configuration
// is behaving correctly.
type IngressValidator struct {
ing *networkingv1.Ingress
fc *frontendconfig.FrontendConfig
frontendNamer namer.IngressFrontendNamer
features []FeatureValidator
whiteboxTests []WhiteboxTest
attribs *IngressValidatorAttributes
client *http.Client
}
// the right SSL certificate is presented
// each path, each host returns the right contents
// Vip for the load balancer. This currently uses the first entry, returns nil
// if the VIP is not available.
func (v *IngressValidator) Vip() *string {
statuses := v.ing.Status.LoadBalancer.Ingress
if len(statuses) == 0 {
return nil
}
ret := statuses[0].IP
return &ret
}
// PerformWhiteboxTests runs additional whitebox tests.
func (v *IngressValidator) PerformWhiteboxTests(gclb *GCLB) error {
for _, w := range v.whiteboxTests {
if err := w.Test(v.ing, v.fc, gclb); err != nil {
return fmt.Errorf("%s failed with error: %v", w.Name(), err)
}
}
return nil
}
// FrontendNamingSchemeTest asserts that correct naming scheme is used.
func (v *IngressValidator) FrontendNamingSchemeTest(gclb *GCLB) error {
// Do not need to validate naming scheme if ingress has no finalizer.
if !common.HasFinalizer(v.ing.ObjectMeta) {
return nil
}
// Find all URL Maps that are not redirect maps
mapName := ""
foundMaps := 0
for k := range gclb.URLMap {
if !strings.Contains(k.Name, "-rm-") {
foundMaps += 1
mapName = k.Name
}
}
// Verify that only one url map exists.
if foundMaps != 1 {
return fmt.Errorf("expected 1 url map to exist but got %d", foundMaps)
}
// Verify that url map is created with correct naming scheme.
if diff := cmp.Diff(v.frontendNamer.UrlMap(), mapName); diff != "" {
return fmt.Errorf("got diff for url map name (-want +got):\n%s", diff)
}
return nil
}
// Check runs all of the checks against the instantiated load balancer.
func (v *IngressValidator) Check(ctx context.Context) *IngressResult {
klog.V(3).Infof("Check Ingress %s/%s attribs=%+v", v.ing.Namespace, v.ing.Name, v.attribs)
ret := &IngressResult{}
ret.Err = v.CheckPaths(ctx, ret)
return ret
}
// CheckPaths checks the host, paths that have been configured. Checks are
// run in parallel.
func (v *IngressValidator) CheckPaths(ctx context.Context, vr *IngressResult) error {
var (
thunks []func()
wg sync.WaitGroup
)
for _, scheme := range v.attribs.schemes() {
if v.ing.Spec.DefaultBackend != nil {
klog.V(2).Infof("Checking default backend for Ingress %s/%s", v.ing.Namespace, v.ing.Name)
// Capture variables for the thunk.
result := &PathResult{Scheme: scheme}
vr.Paths = append(vr.Paths, result)
scheme := scheme
ctx, cancelFunc := context.WithTimeout(ctx, v.attribs.RequestTimeout)
defer cancelFunc()
f := func() {
result.Err = v.checkPath(ctx, scheme, "", pathForDefaultBackend)
wg.Done()
}
thunks = append(thunks, f)
wg.Add(1)
}
for _, rule := range v.ing.Spec.Rules {
if rule.HTTP == nil {
continue
}
for _, path := range rule.HTTP.Paths {
// Capture variables for the thunk.
result := &PathResult{Scheme: scheme, Host: rule.Host, Path: path.Path}
vr.Paths = append(vr.Paths, result)
scheme, host, path := scheme, rule.Host, path.Path
ctx, cancelFunc := context.WithTimeout(ctx, v.attribs.RequestTimeout)
defer cancelFunc()
f := func() {
result.Err = v.checkPath(ctx, scheme, host, path)
wg.Done()
}
thunks = append(thunks, f)
wg.Add(1)
}
}
}
for _, f := range thunks {
go f()
}
klog.V(2).Infof("Waiting for path checks for Ingress %s/%s to finish", v.ing.Namespace, v.ing.Name)
wg.Wait()
for _, r := range vr.Paths {
if r.Err != nil {
klog.V(2).Infof("Got an error checking paths for Ingress %s/%s: %v", v.ing.Namespace, v.ing.Name, r.Err)
return r.Err
}
}
return nil
}
// checkPath performs a check for scheme://host/path.
func (v *IngressValidator) checkPath(ctx context.Context, scheme, host, path string) error {
if v.Vip() == nil {
return fmt.Errorf("ingress %s/%s does not have a VIP", v.ing.Namespace, v.ing.Name)
}
vip := *v.Vip()
url := fmt.Sprintf("%s://%s%s%s", scheme, vip, portStr(v.attribs, scheme), path)
klog.V(3).Infof("Checking Ingress %s/%s url=%q", v.ing.Namespace, v.ing.Name, url)
req, err := http.NewRequest("GET", url, nil)
if err != nil {
return err
}
if host != "" {
req.Host = host
}
req = req.WithContext(ctx)
// Apply modifications for the features.
for _, f := range v.features {
f.ModifyRequest(host, path, req)
}
klog.V(3).Infof("Request is %+v", *req)
resp, err := v.client.Do(req)
if err != nil && err != http.ErrUseLastResponse {
klog.Infof("Ingress %s/%s: %v", v.ing.Namespace, v.ing.Name, err)
return err
}
defer resp.Body.Close()
body, err := io.ReadAll(resp.Body)
if err != nil {
klog.Infof("Ingress %s/%s reading body: %v", v.ing.Namespace, v.ing.Name, err)
return err
}
klog.V(2).Infof("Ingress %s/%s GET %q: %d (%d bytes)", v.ing.Namespace, v.ing.Name, url, resp.StatusCode, len(body))
doStandardCheck := true
// Perform the checks for each of the features.
for _, f := range v.features {
action, err := f.CheckResponse(host, path, resp, body)
if err != nil {
return fmt.Errorf("error from %s validator: %v", f.Name(), err)
}
switch action {
case CheckResponseContinue:
case CheckResponseSkip:
doStandardCheck = false
}
}
if doStandardCheck && resp.StatusCode != 200 {
return fmt.Errorf("ingress %s/%s: GET %q: %d, want 200", v.ing.Namespace, v.ing.Name, url, resp.StatusCode)
}
return nil
}
// portStr returns the ":<port>" for the given scheme. If the port is default
// or scheme is unknown then "" will be returned.
func portStr(a *IngressValidatorAttributes, scheme string) string {
switch scheme {
case "http":
if a.HTTPPort == 80 {
return ""
}
return fmt.Sprintf(":%d", a.HTTPPort)
case "https":
if a.HTTPSPort == 443 {
return ""
}
return fmt.Sprintf(":%d", a.HTTPSPort)
}
return ""
}