Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing ListUrlMaps from LoadBalancers interface #162

Closed
nikhiljindal opened this issue Mar 21, 2018 · 3 comments
Closed

Missing ListUrlMaps from LoadBalancers interface #162

nikhiljindal opened this issue Mar 21, 2018 · 3 comments

Comments

@nikhiljindal
Copy link
Contributor

I see that ListUrlMaps is missing from LoadBalancers interface at: https://github.com/kubernetes/ingress-gce/blob/master/pkg/loadbalancers/interfaces.go#L37.

I need it for kubemci as part of work for GoogleCloudPlatform/k8s-multicluster-ingress#145.

Any objections to me sending a PR to add it?

cc @nicksardo @bowei
@nikhiljindal nikhiljindal mentioned this issue Mar 21, 2018
Closed
@nicksardo
Copy link
Contributor

Sure.

@G-Harmon
Copy link
Contributor

cc me

@nikhiljindal nikhiljindal mentioned this issue Mar 22, 2018
Merged
@nikhiljindal
Copy link
Contributor Author

Thanks for the quick reply @nicksardo
Sent #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicksardo @nikhiljindal @G-Harmon