Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear documentation of spec.rules.http.paths #181

Closed
tvainika opened this issue Mar 29, 2018 · 11 comments
Closed

Unclear documentation of spec.rules.http.paths #181

tvainika opened this issue Mar 29, 2018 · 11 comments
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@tvainika
Copy link

tvainika commented Mar 29, 2018

Documentation of spec.rules.http.paths is unclear regarding, regexp versus wildcard, and multiple matches priority.

According Kubernetes documentation, http.paths should be regular expression. However when testing it on my GCE, it clearly seems to be wildcard match like all examples when looking at GCE load balancer documentation.

Second, I did not find anywhere explanation what happens if there is multiple matching path configurations. Which one will be selected? The one that is listed first or last in my Ingress.yaml, or something else?

@nicksardo nicksardo added the kind/documentation Categorizes issue or PR as related to documentation. label May 4, 2018
@rramkumar1
Copy link
Contributor

/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 6, 2018
@tvainika
Copy link
Author

tvainika commented Aug 7, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 7, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2018
@tvainika
Copy link
Author

tvainika commented Nov 5, 2018

/remove-lifecycle stale

Still in Kubernetes v1.12 this is documented as POSIX regex, but GCE matcher is not regex. See here https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.12/#httpingresspath-v1beta1-extensions

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 5, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2019
@tvainika
Copy link
Author

tvainika commented Feb 3, 2019

/remove-lifecycle stale

Still in Kubernetes v1.12 v1.13 this is documented as POSIX regex, but GCE matcher is not regex. See here
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#httpingresspath-v1beta1-extensions

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2019
@bowei
Copy link
Member

bowei commented Feb 4, 2019

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 4, 2019
@bowei
Copy link
Member

bowei commented Feb 4, 2019

@wyaeld
Copy link

wyaeld commented May 23, 2019

@bowei why is updating the documentation just be clear on the available behaviour such a long process? This issue is over a year old. The differences with ingress-gce vs ingress-nginx are a huge pain point for new users.

@rramkumar1
Copy link
Contributor

rramkumar1 commented May 27, 2019

@wyaeld This was updated a while back, looks like we just forgot to close the issue. The docs live here

Pasting the relevant section here:

"The only supported wildcard character for the path field of an Ingress is the * character. The * character must follow a forward slash (/) and must be the last character in the pattern. For example, /*, /foo/*, and /foo/bar/* are valid patterns, but *, /foo/bar*, and /foo/*/bar are not.

A more specific pattern takes precedence over a less specific pattern. If you have both /foo/* and /foo/bar/*, then /foo/bar/bat is taken to match /foo/bar/*.

For more information about path limitations and pattern matching, see the URL Maps documentation."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

7 participants