failureThreshold of readinessProbe is not reflected to health check

[sonots]

With readinessProbe such as:

        readinessProbe:
          httpGet:
            path: /
            port: 8080
          initialDelaySeconds: 5
          periodSeconds: 5
          timeoutSeconds: 4
          successThreshold: 1
          failureThreshold: 3

A health check was created as:

It seems that failureThreshold is not reflected to unhealthy threshold at

ingress-gce/pkg/backends/syncer.go

Lines 224 to 249 in e50d26d

	func applyProbeSettingsToHC(p *v1.Probe, hc *healthchecks.HealthCheck) {
	healthPath := p.Handler.HTTPGet.Path
	// GCE requires a leading "/" for health check urls.
	if !strings.HasPrefix(healthPath, "/") {
	healthPath = "/" + healthPath
	}
	// Extract host from HTTP headers
	host := p.Handler.HTTPGet.Host
	for _, header := range p.Handler.HTTPGet.HTTPHeaders {
	if header.Name == "Host" {
	host = header.Value
	break
	}
	}
	hc.RequestPath = healthPath
	hc.Host = host
	hc.Description = "Kubernetes L7 health check generated with readiness probe settings."
	hc.TimeoutSec = int64(p.TimeoutSeconds)
	if hc.ForNEG {
	// For NEG mode, we can support more aggressive healthcheck interval.
	hc.CheckIntervalSec = int64(p.PeriodSeconds)
	} else {
	// For IG mode, short healthcheck interval may health check flooding problem.
	hc.CheckIntervalSec = int64(p.PeriodSeconds) + int64(healthchecks.DefaultHealthCheckInterval.Seconds())
	}
	}

[rramkumar1]

Closing in favor of #772