-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Improve ownership of ingress resources in multi-ingress-controller clusters #1071
Comments
The larger design would be more like StorageClass. We have to figure out the future of Ingress wrt lowest-common API vs annotations vs specific Kinds before we invest in that design, I think. Setting the class or an ownership tag is a possible first-step, but we need to think through the race between controllers both trying to set that.. |
@nicksardo ingress claim was one of the ideas of @bprashanth to fix this kubernetes/kubernetes#30151 |
Indeed, this is just a smallest-fix-possible for the current situation. |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Currently, users may accidentally cause ingress controller sync-loops (fighting) simply by adding a controller to a cluster and not having the ingress.class annotation set on an ingress. While it's documented that in clusters with multiple controllers all ingress resources must have the ingress.class annotation set to something specific, this isn't a great user experience.
One option is to have controllers claim ownership of ingress objects - either by setting the ingress.class annotation with the controller's type or use a new annotation. If the user wants to move an ingress from one controller to another, they would need to manually change this flag. Of course, this requires implementation changes in all ingress controllers.
Other ideas or missing anything?
@aledbf @thockin @nikhiljindal @csbell
The text was updated successfully, but these errors were encountered: