Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Improve ownership of ingress resources in multi-ingress-controller clusters #1071

Closed
nicksardo opened this issue Aug 3, 2017 · 6 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@nicksardo
Copy link
Contributor

Currently, users may accidentally cause ingress controller sync-loops (fighting) simply by adding a controller to a cluster and not having the ingress.class annotation set on an ingress. While it's documented that in clusters with multiple controllers all ingress resources must have the ingress.class annotation set to something specific, this isn't a great user experience.

One option is to have controllers claim ownership of ingress objects - either by setting the ingress.class annotation with the controller's type or use a new annotation. If the user wants to move an ingress from one controller to another, they would need to manually change this flag. Of course, this requires implementation changes in all ingress controllers.

Other ideas or missing anything?

@aledbf @thockin @nikhiljindal @csbell

@thockin
Copy link
Member

thockin commented Aug 3, 2017

The larger design would be more like StorageClass. We have to figure out the future of Ingress wrt lowest-common API vs annotations vs specific Kinds before we invest in that design, I think.

Setting the class or an ownership tag is a possible first-step, but we need to think through the race between controllers both trying to set that..

@aledbf
Copy link
Member

aledbf commented Aug 3, 2017

@nicksardo ingress claim was one of the ideas of @bprashanth to fix this kubernetes/kubernetes#30151

@nicksardo
Copy link
Contributor Author

The larger design would be more like StorageClass. We have to figure out the future of Ingress wrt lowest-common API vs annotations vs specific Kinds before we invest in that design, I think.

Indeed, this is just a smallest-fix-possible for the current situation.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 7, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants