Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip the rbac creation in admission-webhooks #11375

Closed
rgaduput opened this issue May 22, 2024 · 1 comment · Fixed by #11376
Closed

Option to skip the rbac creation in admission-webhooks #11375

rgaduput opened this issue May 22, 2024 · 1 comment · Fixed by #11376
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@rgaduput
Copy link
Contributor

An option to skip the RBAC resources creation for admission-webhooks. This helps while installing the chart in restricted permissions (assuming that these resources will be pre-created).
We already have such option in ingress-nginx but missing in admisson-webhooks.

@rgaduput rgaduput added the kind/feature Categorizes issue or PR as related to a new feature. label May 22, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 22, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rgaduput added a commit to rgaduput/ingress-nginx that referenced this issue May 22, 2024
…sion-webhooks (kubernetes#11375)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
rgaduput added a commit to rgaduput/ingress-nginx that referenced this issue May 22, 2024
…ADME (kubernetes#11375)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
rgaduput added a commit to rgaduput/ingress-nginx that referenced this issue May 29, 2024
… for admission-webhooks (kubernetes#11375)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
rgaduput added a commit to rgaduput/ingress-nginx that referenced this issue May 29, 2024
Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
rgaduput added a commit to rgaduput/ingress-nginx that referenced this issue Jun 2, 2024
…11375)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
k8s-ci-robot pushed a commit that referenced this issue Jun 3, 2024
* Add an option to skip rbac resources creation in helm chart for admission-webhooks (#11375)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* Add an option to skip rbac resources creation in helm chart update README (#11375)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* Add an option to skip serviceAccount resources creation in helm chart for admission-webhooks (#11375)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* Add helm chart tests for admission-webhooks (#11375)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* Chart make admission webhook patch job RBAC configurable (#11375)

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>

* Update charts/ingress-nginx/tests/admission-webhooks/job-patch/clusterrole_test.yaml

Co-authored-by: Marco Ebert <marco_ebert@icloud.com>

* Update charts/ingress-nginx/tests/admission-webhooks/job-patch/clusterrolebinding_test.yaml

Co-authored-by: Marco Ebert <marco_ebert@icloud.com>

* Update charts/ingress-nginx/tests/admission-webhooks/job-patch/role_test.yaml

Co-authored-by: Marco Ebert <marco_ebert@icloud.com>

* Update charts/ingress-nginx/tests/admission-webhooks/job-patch/rolebinding_test.yaml

Co-authored-by: Marco Ebert <marco_ebert@icloud.com>

* Update charts/ingress-nginx/tests/admission-webhooks/job-patch/serviceaccount_test.yaml

Co-authored-by: Marco Ebert <marco_ebert@icloud.com>

---------

Signed-off-by: Reddysekhar Gaduputi <gsekhar73@gmail.com>
Co-authored-by: Marco Ebert <marco_ebert@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants