Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ginkgo bump requirement reported in CI e2e #11466

Closed
longwuyuan opened this issue Jun 15, 2024 · 3 comments · Fixed by #11467
Closed

ginkgo bump requirement reported in CI e2e #11466

longwuyuan opened this issue Jun 15, 2024 · 3 comments · Fixed by #11467
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@longwuyuan
Copy link
Contributor

longwuyuan commented Jun 15, 2024

What happened:

  • ginkgo bump requirement was reported while running e2e locally
Status: Downloaded newer image for registry.k8s.io/ingress-nginx/e2e-test-runner@sha256:6bcba53b14d396177414e01f20e9111f1c009ac3b476a9b7668bb98d12bd5e85
Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:                         
    2.17.1                                    
  Mismatched package versions found:
    2.19.0 used by e2e                        

  Ginkgo will continue to attempt to run but you may see errors (including flag
  parsing errors) and should either update your go.mod or your version of the
  Ginkgo CLI to match.                        

  To install the matching version of the CLI run
    go install github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file.  Alternatively you can use
    go run github.com/onsi/ginkgo/v2/ginkgo
  from a path that contains a go.mod file to invoke the matching version of the
  Ginkgo CLI.                                 

  If you are attempting to test multiple packages that each have a different
  version of the Ginkgo library with a single Ginkgo CLI that is currently
  unsupported.                                
                                              
go: downloading github.com/onsi/ginkgo/v2 v2.19.0
go: downloading github.com/stretchr/testify v1.9.0

  • I tried to run kind e2e test locally like thus
FOCUS="backend-protocol" make kind-e2e-test
  • Its possible that this is yet another repeat event where dependabot PR bumped ginkgo from v2.17.1 to v2.19.0 but the hardcoded pinned locations in the project were not changed to sync with the dependabot PR change

  • The above suspicion is kinda more likely because its visible in the screenshot below
    image

  • There are plans to remove that test-runner image which will remove at least some of this pinned versions but that is work-in-progress (also owned by me)

  • So this issue is to track current status and record opinions or take actions (if any)

/triage accepted

@Gacko please check and advise if I can do anything

@longwuyuan longwuyuan added the kind/bug Categorizes issue or PR as related to a bug. label Jun 15, 2024
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. needs-priority labels Jun 15, 2024
@longwuyuan
Copy link
Contributor Author

/assign @Gacko

@Gacko
Copy link
Member

Gacko commented Jun 15, 2024

Ah, sorry! I think I lgtm'd that Dependabot PR recently. Gonna create a follow up to align it everywhere. Thanks for pointing that out! 🙂

@Gacko
Copy link
Member

Gacko commented Jun 15, 2024

Here's the PR. Unfortunately you cannot lgtm it, so I'll post it to #ingress-nginx-dev and see if someone else wants to. 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants