Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation for per-Ingress upstream-keepalive-connections #11472

Open
robertxiaoxiao opened this issue Jun 17, 2024 · 3 comments
Open

Add annotation for per-Ingress upstream-keepalive-connections #11472

robertxiaoxiao opened this issue Jun 17, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@robertxiaoxiao
Copy link

What do you want to happen?

I'm hoping for an annotation variant of "upstream-keepalive-connections" per ingress. we want to customized different upstream section configs like native Nginx config when using ingress controller in AKS. Now upstream section is integrated as one interface as below.
alt text

What happened

Now we cannot customize upstream section per ingress. My team hit a 421 issue when we want to separate requests in multi ingress to different upstream with different keep_alive configs. One is enabled keepalive and other one is disabled for some reasons.

What you expected to happen

we have found another closed but not resolved issue several years ago. #2441

Anything else we need to know

we tried several method to fix upstream section config per ingress but all failed. now we use native Openresty to implement proxy logics. this would be a nice thing to make available in ingress nginx controller.

@robertxiaoxiao robertxiaoxiao added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 17, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Jun 17, 2024
@robertxiaoxiao
Copy link
Author

I am trying to use lua scripts to workaround in my issue as docs below. will update if that workaround works.
https://github.com/openresty/lua-nginx-module?tab=readme-ov-file#tcpsocksetkeepalive

@Gacko
Copy link
Member

Gacko commented Jun 17, 2024

I'm not sure if this is even possible since NGINX does not provide that on its own:

https://nginx.org/en/docs/http/ngx_http_upstream_module.html#keepalive

This can only be configured inside the context of an upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

3 participants