Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenTelemetry Module #11496

Open
shugg opened this issue Jun 24, 2024 · 3 comments
Open

Update OpenTelemetry Module #11496

shugg opened this issue Jun 24, 2024 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@shugg
Copy link

shugg commented Jun 24, 2024

Ingress-NGINX 1.10.0 has dropped support for OpenTracing and Zipkin, favoring OpenTelemetry instead. The OpenTelemetry module used by Ingress-NGINX is based on a commit from September 12, 2023, and has received updates since then.

Could you please update the module to a more recent version?

The commit I am interested in enhances the module by setting the span status to error when an HTTP request returns a 5xx status code, following the OpenTelemetry specification similar to the previously supported OpenTracing module.

@shugg shugg added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 24, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 24, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@longwuyuan
Copy link
Contributor

/assign @esigo

@bforchhammer
Copy link

For what it's worth, with the current helm chart version 4.11.0 I seem to end up with two variants of the otel_ngx_module.so file:

  • one in /etc/nginx/modules/otel_ngx_module.so <-- this one is loaded by the generated nginx.conf
  • another one in /modules_mount/etc/nginx/modules/otel/otel_ngx_module.so, which seems to be ignored?

My impression from looking around the code was that the modules_mount volume is intended as a mechanism to swap out/add extra modules, ie. maybe one could use that to change the bundled otel module version? I haven't been able to figure out how or whether that could work though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

5 participants