Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default redirect to 301 to support old internet explorer versions #2002

Closed
thomaspeitz opened this issue Jan 30, 2018 · 1 comment
Closed

Comments

@thomaspeitz
Copy link
Contributor

Ingress Controller 0.10.2
Kubernetes 1.8.x

What happened:
This morning some of our customers told us they can not reach our website. We realized that only customers with windows systems contacted us. After some research we found out that annotation nginx.ingress.kubernetes.io/force-ssl-redirect: "true" uses a 308 rewrite. Which is the best way to rewrite but sadly it does not support all clients. Old Internet Explorer versions have problems with it (for example win 7). We could fix it ourselves quickly through:
Configmap:
http-redirect-code: "301"

What you expected to happen:
I would expect to use 301 as default after this incidence. I bet there are more companies out there which will fall into this trap. 308 is faster but it is saver to use 301.

How to reproduce it
Create a ingress rule with nginx.ingress.kubernetes.io/force-ssl-redirect: "true" annotation and visit the website via http on an internet explorer.
https://www.browserling.com/browse/win/vista/ie/9/$YOURDOMAIN

So basically i would suggest that i make a pr to change default rewrite to 301. Change documentations that we use 301 because of internet explorer. I would keep the text about 308 and tell our users that it makes sense to use 308 if ie is unimportant.

What are you opinions about that?

Greetings, Thomas

@thomaspeitz
Copy link
Contributor Author

Closed in favour of finding a closed issue and reopening it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant