Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: gRPC support #2207

Closed
egeland opened this issue Mar 18, 2018 · 8 comments · Fixed by #2223
Closed

Feature Request: gRPC support #2207

egeland opened this issue Mar 18, 2018 · 8 comments · Fixed by #2223
Projects

Comments

@egeland
Copy link
Contributor

egeland commented Mar 18, 2018

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
FEATURE REQUEST

NGINX has announced gRPC load balancing support in the upcoming release - see https://www.nginx.com/blog/nginx-1-13-10-grpc/

Please add support for this to the ingress controller

@aledbf
Copy link
Member

aledbf commented Mar 18, 2018

@egeland this is not released yet. We need to wait for 1.3.10. The code for gRPC is only present in hg.

@egeland
Copy link
Contributor Author

egeland commented Mar 18, 2018

I know - which is why I made sure to say "upcoming release" 😉

@aledbf aledbf added this to TODO in 0.13.0 Mar 18, 2018
@panamafrancis
Copy link

I'd like to get the ball rolling on this.

I assume the following would need to be implemented:

  1. A new template file just for gRPC services
  2. A new set of annotations eg nginx.ingress.kubernetes.io/grpc-*
  3. Either build a new default backend for gRPC or extend the existing one
  4. Documentation.

What i'm not sure about is the conflict between existing annotations and gRPC, can they be re-used or should all gRPC annotations be prefixed grpc-*?

@aledbf
Copy link
Member

aledbf commented Mar 19, 2018

@panamafrancis first, let's wait for the release.

After that, I will update the nginx image to add support for gRPC.
Then we just need one annotation to add support for gRPC, something like nginx.ingress.kubernetes.io/grpc-backend just to enable the feature and see what's the behavior. Later we can start adding new configurations for all the gRPC settings.

@aledbf
Copy link
Member

aledbf commented Mar 20, 2018

To any user watching this issue: do you have a stateless gRPC service ready for Kubernetes?
I want to use something already tested so we can focus just on NGINX.

Temporal image: quay.io/aledbf/nginx-ingress-controller:0.345
The annotation nginx.ingress.kubernetes.io/grpc-backend: "true" is required to enable this feature.
If the gRPC service required TLS then also add the annotation
nginx.ingress.kubernetes.io/secure-backends: "true"

Thanks in advance

@pcj pcj mentioned this issue Apr 2, 2018
@racyber
Copy link

racyber commented Apr 26, 2018

Does this feature is part of the 0.13.0?
I'm using helm to install ngnix and currently the values are:
repository: quay.io/kubernetes-ingress-controller/nginx-ingress-controller
tag: "0.13.0"

@aledbf
Copy link
Member

aledbf commented Apr 26, 2018

@racyber
Copy link

racyber commented Apr 26, 2018

@aledbf cool thanks!

the annotations docs is out of date, this flag is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants