Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--tcp-services-configmap not reloading #4804

Closed
holmesb opened this issue Dec 2, 2019 · 4 comments
Closed

--tcp-services-configmap not reloading #4804

holmesb opened this issue Dec 2, 2019 · 4 comments

Comments

@holmesb
Copy link

holmesb commented Dec 2, 2019

When a change is made to the configmap referred by the --tcp-services-configmap parameter, the change is not effective and the TCP port cannot be contacted. Deleting the nginx controller pod is necessary, which involves downtime.

What you expected to happen:
Nginx reloads this configmap in response to the change.

How to reproduce it (as minimally and precisely as possible):
Change configmap. New TCP port will not be communicable. Manually reloading by exec-ing onto the pod and typing command:

www-data@nginx1:/etc/nginx$ nginx -c /etc/nginx/nginx.conf -s reload
2019/12/02 13:54:07 [notice] 15627#15627: signal process started

doesn't enact the change either.

The configmap content is reaching /etc/nginx/nginx.conf fine. I can grep this file for the new port number:

www-data@nginx1:/etc/nginx$ cat nginx.conf |grep 12345
                set $service_port   "{0 12345 }";
                        set $proxy_upstream_name    "service1-12345";
                        ngx.var.proxy_upstream_name="service1-12345";
                listen                  12345; 

It just isn't taking effect without restarting the pod. Others have noticed this issue too.

NGINX Ingress controller version: 0.25.1

Kubernetes version (use kubectl version): 1.15.3

@holmesb
Copy link
Author

holmesb commented Feb 7, 2020

Anyone who uses TCP load-balancing able to reproduce this problem? Downtime every TCP port change isn't viable.

@aledbf
Copy link
Member

aledbf commented Feb 22, 2020

Closing. Please update to 0.29.0. Reopen if the issue persists after the update

@aledbf aledbf closed this as completed Feb 22, 2020
@nrvmodi
Copy link

nrvmodi commented May 4, 2020

I was using image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.31.1.

I had tested new port reloading in tcp-services.yaml file. So for that I need to compulsary apply tcp-services.yaml and nginx-ingress-controller.yaml file once again to take impact of new port in nginx-ingress-controller pod.

I have also observed that ingress-nginx-controller pod is not killed by kubernetes to apply that configmap.
Before and after applying those changes my pod name is same.

@GregOwen
Copy link

GregOwen commented May 4, 2020

I'm also seeing this same issue on image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.31.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants