Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default HTTP2 header size decreased, breaking oauth. #404

Closed
t-8ch opened this issue Mar 8, 2017 · 2 comments · Fixed by #409
Closed

Default HTTP2 header size decreased, breaking oauth. #404

t-8ch opened this issue Mar 8, 2017 · 2 comments · Fixed by #409
Labels

Comments

@t-8ch
Copy link

t-8ch commented Mar 8, 2017

In #376/#392 http2_max_field_size has been made configurable.
This changed the default from 4K to 1K breaking our oauth Bearer token header.

For client_header_buffer_size a small size is enough, as larger buffers are used if necessary.
For http2_max_field_size no larger buffers are allocated.

So I think it would be better to use the $cfg.LargeClientHeaderBuffers size for http2_max_field_size

(And http2_max_field_size is for the compressed key-value pair. For the decompressed header there is http2_max_header_size)

@aledbf
Copy link
Member

aledbf commented Mar 8, 2017

@t-8ch apologies for the error. As I said in #376 we tried to use the same value which from your report is not the right approach. I will ad a new config HTTP2MaxFieldSize.

@t-8ch
Copy link
Author

t-8ch commented Mar 9, 2017

@aledbf No reason to apologise :-)
Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants