Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field FileSHA in BasicDigest struct #1046

Merged
merged 1 commit into from Aug 1, 2017
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 31, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf added this to In Progress in nginx 0.9-beta.12 Jul 31, 2017
@aledbf aledbf force-pushed the auth-sha branch 2 times, most recently from ef42b30 to 8deca37 Compare July 31, 2017 19:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 44.071% when pulling 8deca37 on aledbf:auth-sha into 65e8cec on kubernetes:master.

@aledbf
Copy link
Member Author

aledbf commented Jul 31, 2017

ping @jcmoraisjr

@jcmoraisjr
Copy link
Contributor

About the commit: adding the FileSHA field is fine and fixes the reload.

Any idea to the false positive and annoying warning below whenever changing a non cert/key pair or a CA secret?

 func (ic *GenericController) syncSecret(key string) {
     glog.V(3).Infof("starting syncing of secret %v", key)
     cert, err := ic.getPemCertificate(key)
     if err != nil {
         glog.Warningf("error obtaining PEM from secret %v: %v", key, err)
         return
     }

@aledbf aledbf merged commit 848144a into kubernetes:master Aug 1, 2017
@aledbf aledbf deleted the auth-sha branch August 1, 2017 03:12
@aledbf aledbf moved this from In Progress to done in nginx 0.9-beta.12 Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants