Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some go style mistakes about fmt.Errorf #111

Merged
merged 1 commit into from
Mar 17, 2017
Merged

fix some go style mistakes about fmt.Errorf #111

merged 1 commit into from
Mar 17, 2017

Conversation

chentao1596
Copy link

I think we should follow this request: https://github.com/golang/go/wiki/CodeReviewComments#error-strings, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 6, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.733% when pulling d995d0e on chentao1596:fix-go-style-mistake-errorf into 5186e93 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jan 8, 2017

@chentao1596 this changes code in the gce controller. For that reason I'm assigning @bprashanth

@chentao1596
Copy link
Author

@bprashanth hi, can you help to have a look, thank you!

@nicksardo
Copy link
Contributor

Can you go through and remove all the ending periods from generated error strings, please?

@chentao1596 chentao1596 changed the title fix some go style mistakes about fmt.Errorf WIP: fix some go style mistakes about fmt.Errorf Mar 14, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 43.066% when pulling b56451b on chentao1596:fix-go-style-mistake-errorf into 7c17dc3 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 43.066% when pulling b56451b on chentao1596:fix-go-style-mistake-errorf into 7c17dc3 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.215% when pulling fe0c535 on chentao1596:fix-go-style-mistake-errorf into 3d681cd on kubernetes:master.

@chentao1596 chentao1596 force-pushed the fix-go-style-mistake-errorf branch 3 times, most recently from edf6040 to 37bdb39 Compare March 17, 2017 00:54
@chentao1596
Copy link
Author

@nicksardo All folders(except vendor) has been done, PTAL, thank you!

@chentao1596 chentao1596 changed the title WIP: fix some go style mistakes about fmt.Errorf fix some go style mistakes about fmt.Errorf Mar 17, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.177% when pulling 37bdb39 on chentao1596:fix-go-style-mistake-errorf into a5f8fe2 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 43.21% when pulling 37bdb39 on chentao1596:fix-go-style-mistake-errorf into a5f8fe2 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 43.21% when pulling 37bdb39 on chentao1596:fix-go-style-mistake-errorf into a5f8fe2 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 43.21% when pulling 37bdb39 on chentao1596:fix-go-style-mistake-errorf into a5f8fe2 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 43.226% when pulling 37bdb39 on chentao1596:fix-go-style-mistake-errorf into a5f8fe2 on kubernetes:master.

@nicksardo nicksardo merged commit 62070a1 into kubernetes:master Mar 17, 2017
@chentao1596 chentao1596 deleted the fix-go-style-mistake-errorf branch March 17, 2017 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nicksardo nicksardo

@bprashanth bprashanth

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@chentao1596 @k8s-reviewable @coveralls @aledbf @nicksardo @bprashanth @k8s-ci-robot @chentao11596