-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some go style mistakes about fmt.Errorf #111
Merged
nicksardo
merged 1 commit into
kubernetes:master
from
chentao1596:fix-go-style-mistake-errorf
Mar 17, 2017
Merged
fix some go style mistakes about fmt.Errorf #111
nicksardo
merged 1 commit into
kubernetes:master
from
chentao1596:fix-go-style-mistake-errorf
Mar 17, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@chentao1596 this changes code in the gce controller. For that reason I'm assigning @bprashanth |
@bprashanth hi, can you help to have a look, thank you! |
Can you go through and remove all the ending periods from generated error strings, please? |
abafb78
to
b56451b
Compare
b56451b
to
fe0c535
Compare
edf6040
to
37bdb39
Compare
@nicksardo All folders(except vendor) has been done, PTAL, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should follow this request: https://github.com/golang/go/wiki/CodeReviewComments#error-strings, thank you!