Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unmodified PeriodSeconds setting #1214

Closed
wants to merge 1 commit into from
Closed

Use unmodified PeriodSeconds setting #1214

wants to merge 1 commit into from

Conversation

manigandham
Copy link

Use actual interval setting from readiness probe instead of modifying.

Fix #1213

Use actual interval setting from readiness probe instead of modifying.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@manigandham
Copy link
Author

CLA signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 22, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 44.463% when pulling ac9f960 on manigandham:master into 31d45d8 on kubernetes:master.

@nicksardo
Copy link
Contributor

This is by design. The GCP health check isn't supposed to be a 1:1 check with the readiness probe. The health checks are for the nodes, not the pods. Adding the 60 seconds prevents the GCP health checks from overwhelming the containers if the number of nodes greatly out pods.

@manigandham
Copy link
Author

Ah ok, makes sense. Thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants