Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivial fixes in core/pkg/net #1218

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Trivial fixes in core/pkg/net #1218

merged 1 commit into from
Aug 22, 2017

Conversation

anfernee
Copy link
Member

@anfernee anfernee commented Aug 22, 2017

Naive PR.

  • I feel string comparison is hacky to judge an IP is IPv6 or not. Simplify util method IsIPV6.
  • Fixes parsing of /etc/resolv.conf

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@anfernee
Copy link
Member Author

CLA signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 22, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 44.427% when pulling 179eee8 on anfernee:master into ed3803c on kubernetes:master.

@anfernee anfernee changed the title Simplify util method IsIPV6 Trivial fixes in core/pkg/net Aug 22, 2017
@aledbf
Copy link
Member

aledbf commented Aug 22, 2017

@anfernee please squash the commits

@aledbf aledbf self-assigned this Aug 22, 2017
@aledbf
Copy link
Member

aledbf commented Aug 22, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 44.388% when pulling f2d9d15 on anfernee:master into ed3803c on kubernetes:master.

@anfernee
Copy link
Member Author

@aledbf thanks for reviewing. There should be squash and merge button to merge in github. I don't need to squash it, right?

@aledbf
Copy link
Member

aledbf commented Aug 22, 2017

@anfernee please squash manually.

- Simplify util method IsIPV6
- Skip ';'-prefixed lines in /etc/resolv.conf as comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 44.414% when pulling 99227da on anfernee:master into ed3803c on kubernetes:master.

@aledbf aledbf merged commit 3463ddb into kubernetes:master Aug 22, 2017
@aledbf
Copy link
Member

aledbf commented Aug 22, 2017

@anfernee thanks!

@aledbf aledbf added this to done in nginx 0.9-beta.12 Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants