Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annotations doc with base-url-scheme #1227

Merged
merged 1 commit into from Aug 23, 2017

Conversation

danielqsj
Copy link
Contributor

Update annotations doc with base-url-scheme

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 23, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.407% when pulling a22e91b on danielqsj:update-annotation-doc into f0144a1 on kubernetes:master.

@aledbf aledbf self-assigned this Aug 23, 2017
@aledbf
Copy link
Member

aledbf commented Aug 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2017
@aledbf
Copy link
Member

aledbf commented Aug 23, 2017

@danielqsj thanks!

@aledbf aledbf merged commit 4e979ac into kubernetes:master Aug 23, 2017
@aledbf aledbf added this to done in nginx 0.9-beta.12 Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants