Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConfigMap link in doc #1400

Merged
merged 1 commit into from Sep 24, 2017
Merged

Conversation

maxlaverse
Copy link
Contributor

The link to the ConfigMap introduction is broken on the main Nginx README.

I propose to change it to the kubernetes.io task explaining what a ConfigMap is.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 21, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 43.727% when pulling 7a1f604 on maxlaverse:fix_configmap_link into 37bd14d on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Sep 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2017
@aledbf
Copy link
Member

aledbf commented Sep 24, 2017

@maxlaverse thanks!

@aledbf aledbf merged commit b01d2de into kubernetes:master Sep 24, 2017
@maxlaverse maxlaverse deleted the fix_configmap_link branch September 24, 2017 19:30
@aledbf aledbf added this to done in nginx 0.9-beta.14 Sep 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants