[GCLB] Gracefully handle lack of IAM rights for modifying firewall #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-ci-robot
added
the
size/L
nicksardo
force-pushed
the
alt-xpn-firewall
branch
from
7b4278e
to
c968e75
Compare
nicksardo
commented
Oct 6, 2017
| type FirewallSyncError struct { | ||
| Internal error | ||
| Message string | ||
| } |
There was a problem hiding this comment.
Let me know if you have any better ideas on how this error should look.
nikhiljindal
reviewed
Oct 6, 2017
| } else if utils.IsForbiddenError(err) && fr.cloud.OnXPN() { | ||
| gcloudCmd := gce.FirewallToGCloudDeleteCmd(name, fr.cloud.NetworkProjectID()) | ||
| glog.V(3).Infof("Could not attempt delete of L7 firewall on XPN cluster. %q needs to be ran.", gcloudCmd) | ||
| // FirewallXPN error is not returned here because there is no ingress for attaching. |
There was a problem hiding this comment.
It should return an error irrespective? The caller knows that there is no ingress and hence it will just log it
| type FirewallSyncError struct { | ||
| Internal error | ||
| Message string | ||
| } |
| NetworkURL() string | ||
| OnXPN() bool |
There was a problem hiding this comment.
Add a comment saying this will return true if XPN is enabled in GCP project.
optional: Probably also link to some XPN documentation?
|
Thanks this looks a lot cleaner now! minor comments. mostly looks good |
nicksardo
force-pushed
the
alt-xpn-firewall
branch
from
c968e75
to
a061b2f
Compare
|
Changes Unknown when pulling a061b2f on nicksardo:alt-xpn-firewall into ** on kubernetes:master**. |
|
Moving to new repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.