Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template): wrap IPv6 addresses in [] #829

Merged
merged 1 commit into from Jun 9, 2017

Conversation

rlguarino
Copy link
Contributor

Add formatIP helper function which will wrap IPv6 addresses
in [] and print IPv4 addresses as is.

Closes #828

Add formatIP helper function which will wrap IPv6 addresses
in [] and print IPv4 addresses as is.

Closes kubernetes#828
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@rlguarino
Copy link
Contributor Author

@k8s-ci-robot I've signed the CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 9, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 46.523% when pulling 54f6729 on rlguarino:ross/2017-06-08T18-48-35-07-00 into d556cc0 on kubernetes:master.

@aledbf aledbf self-assigned this Jun 9, 2017
@aledbf
Copy link
Member

aledbf commented Jun 9, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2017
@aledbf
Copy link
Member

aledbf commented Jun 9, 2017

@rlguarino thanks!

@aledbf aledbf merged commit dbb12af into kubernetes:master Jun 9, 2017
@aledbf aledbf added this to done in nginx 0.9-beta.8 Jun 9, 2017
@rlguarino rlguarino deleted the ross/2017-06-08T18-48-35-07-00 branch June 9, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants