-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KObj should be able to handle nil objects #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
maybe as a follow-up we should consider either: a) having object-ref's log representation explicitly report when it's completely empty to make this obvious "b" probably has allocation-related perf implications, so probably should do "a" In the mean time, I think this is fine though -- prob better not to panic when a nil object is passed to a log line 😅 /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, ehashman, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Because of differences between interface with nil value and just nil, I don't think this PR fixes the underlying issue. Full explanation kubernetes/kubernetes#100155 |
What this PR does / why we need it:
Prevents
klog.KObj
from panicking when passednil
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):See kubernetes/kubernetes#100109
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: