Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle panics in error.Error #284

Closed
pohly opened this issue Feb 4, 2022 · 0 comments · Fixed by #299
Closed

handle panics in error.Error #284

pohly opened this issue Feb 4, 2022 · 0 comments · Fixed by #299
Assignees
@pohly
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pohly
Copy link

pohly commented Feb 4, 2022

/kind feature

Describe the solution you'd like

When klog calls error.Error(), it should catch panics the same way it currently does for fmt.Stringer().

/assign
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 4, 2022
@pohly pohly mentioned this issue Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pohly pohly

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

handle panics in MarshalLog, Error, String pohly/klog
2 participants
@pohly @k8s-ci-robot